From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 00/12] ADD USB3.1 HOST, Peri and DRD support
Date: Sat, 21 Jan 2023 11:06:02 +0100 [thread overview]
Message-ID: <Y8u5Cpl2B5b2mzPp@kroah.com> (raw)
In-Reply-To: <OS0PR01MB59221827031B393F6FB693E786CA9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On Sat, Jan 21, 2023 at 09:59:53AM +0000, Biju Das wrote:
> Hi Greg,
>
> Thanks for the feedback.
>
> > Subject: Re: [PATCH v2 00/12] ADD USB3.1 HOST, Peri and DRD support
> >
> > On Thu, Jan 12, 2023 at 09:58:54PM +0000, Biju Das wrote:
> > > This patch series aims to add USB3.1 HOST, Peri and DRD support on
> > > RZ/V2M EVK platform.
> > >
> > > The reset for both host and peri are located in USB3DRD block. The
> > > USB3DRD registers are mapped in the AXI address space of the
> > > Peripheral module.
> > >
> > > RZ/V2M XHCI is similar to R-Car XHCI but it doesn't require any
> > > firmware.
> > >
> > > Host/device needs to do reset release and set the host/device function
> > > on DRD module, before accessing any registers.
> >
> > After applying this series and building it on x86_64 I get the following
> > build errors:
> >
> > ERROR: modpost: "rzv2m_usb3drd_reset" [drivers/usb/host/xhci-plat-hcd.ko]
> > undefined!
> > ERROR: modpost: "rzv2m_usb3drd_reset"
> > [drivers/usb/gadget/udc/renesas_usb3.ko] undefined!
>
> The file drivers/usb/gadget/udc/rzv2m_usb3drd.c is not getting compiled,
>
> If USB_RZV2M_USB3DRD=y, USB_XHCI_RZV2M=m and USB_RENESAS_USB3=m and
> Because of that modpost is giving undefined error.
>
> So I have updated the KCONFIG like below and now it builds OK now. I will send next version
> based on this, if there are no comments.
>
> -- a/drivers/usb/gadget/udc/Kconfig
> +++ b/drivers/usb/gadget/udc/Kconfig
> @@ -180,10 +180,17 @@ config USB_RENESAS_USBHS_UDC
> gadget drivers to also be dynamically linked.
>
> config USB_RZV2M_USB3DRD
> + tristate 'Renesas USB3.1 DRD controller'
> depends on ARCH_R9A09G011 || COMPILE_TEST
> - bool
> - default y if USB_XHCI_RZV2M
> - default y if USB_RENESAS_USB3
> + default y if USB_XHCI_RZV2M=y
> + default y if USB_RENESAS_USB3=y
These should just be:
default USB_XHCI_RZV2M
default USB_RENESAS_USB3
right?
thanks,
greg k-h
next prev parent reply other threads:[~2023-01-21 10:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 21:58 [PATCH v2 00/12] ADD USB3.1 HOST, Peri and DRD support Biju Das
2023-01-12 21:58 ` [PATCH v2 01/12] dt-bindings: usb: renesas,usb-xhci: Document RZ/V2M support Biju Das
2023-01-12 21:58 ` [PATCH v2 02/12] dt-bindings: usb: renesas,usb3-peri: Update reset, clock-name and interrupts properties Biju Das
2023-01-13 20:49 ` Rob Herring
2023-01-12 21:58 ` [PATCH v2 03/12] dt-bindings: usb: renesas,usb3-peri: Document RZ/V2MA bindings Biju Das
2023-01-13 20:49 ` Rob Herring
2023-01-12 21:58 ` [PATCH v2 04/12] dt-bindings: usb: Add RZ/V2M USB3DRD binding Biju Das
2023-01-13 20:50 ` Rob Herring
2023-01-12 21:59 ` [PATCH v2 10/12] arm64: dts: renesas: r9a09g011: Add USB3 DRD, device and host nodes Biju Das
2023-01-12 21:59 ` [PATCH v2 11/12] arm64: dts: renesas: rzv2mevk2: Enable USB3 DRD, Peripheral and Host Biju Das
2023-01-12 21:59 ` [PATCH v2 12/12] arm64: dts: renesas: rzv2mevk2: Enable USB3 role switch Biju Das
2023-01-19 13:10 ` [PATCH v2 00/12] ADD USB3.1 HOST, Peri and DRD support Greg Kroah-Hartman
2023-01-21 9:59 ` Biju Das
2023-01-21 10:06 ` Greg Kroah-Hartman [this message]
2023-01-21 10:54 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8u5Cpl2B5b2mzPp@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=felipe.balbi@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox