* [PATCH] arm64: dts: qcom: sm8550-mtp: drop incorrect vdd-l6-l16-supply
@ 2023-01-27 11:19 Krzysztof Kozlowski
2023-01-27 11:23 ` Konrad Dybcio
2023-01-27 11:34 ` Abel Vesa
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-27 11:19 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Neil Armstrong, Abel Vesa, linux-arm-msm,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
There is no vdd-l6-l16 supply in qcom,pm8550-rpmh-regulators.
Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
index 725d3bc3ee72..d6ae80414654 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
@@ -47,7 +47,6 @@ regulators-0 {
vdd-bob2-supply = <&vph_pwr>;
vdd-l2-l13-l14-supply = <&vreg_bob1>;
vdd-l3-supply = <&vreg_s4g_1p3>;
- vdd-l6-l16-supply = <&vreg_bob1>;
vdd-l6-l7-supply = <&vreg_bob1>;
vdd-l8-l9-supply = <&vreg_bob1>;
vdd-l11-supply = <&vreg_s4g_1p3>;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8550-mtp: drop incorrect vdd-l6-l16-supply
2023-01-27 11:19 [PATCH] arm64: dts: qcom: sm8550-mtp: drop incorrect vdd-l6-l16-supply Krzysztof Kozlowski
@ 2023-01-27 11:23 ` Konrad Dybcio
2023-01-27 11:34 ` Abel Vesa
1 sibling, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2023-01-27 11:23 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Neil Armstrong, Abel Vesa, linux-arm-msm,
devicetree, linux-kernel
On 27.01.2023 12:19, Krzysztof Kozlowski wrote:
> There is no vdd-l6-l16 supply in qcom,pm8550-rpmh-regulators.
>
> Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
@Abel, shouldn't this be l5-l16? Such combination would be
valid as per the driver, but please recheck with schematics.
Konrad
> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> index 725d3bc3ee72..d6ae80414654 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> @@ -47,7 +47,6 @@ regulators-0 {
> vdd-bob2-supply = <&vph_pwr>;
> vdd-l2-l13-l14-supply = <&vreg_bob1>;
> vdd-l3-supply = <&vreg_s4g_1p3>;
> - vdd-l6-l16-supply = <&vreg_bob1>;
> vdd-l6-l7-supply = <&vreg_bob1>;
> vdd-l8-l9-supply = <&vreg_bob1>;
> vdd-l11-supply = <&vreg_s4g_1p3>;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8550-mtp: drop incorrect vdd-l6-l16-supply
2023-01-27 11:19 [PATCH] arm64: dts: qcom: sm8550-mtp: drop incorrect vdd-l6-l16-supply Krzysztof Kozlowski
2023-01-27 11:23 ` Konrad Dybcio
@ 2023-01-27 11:34 ` Abel Vesa
2023-01-27 11:38 ` Abel Vesa
2023-01-27 12:17 ` Krzysztof Kozlowski
1 sibling, 2 replies; 5+ messages in thread
From: Abel Vesa @ 2023-01-27 11:34 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, devicetree,
linux-kernel
On 23-01-27 12:19:13, Krzysztof Kozlowski wrote:
> There is no vdd-l6-l16 supply in qcom,pm8550-rpmh-regulators.
>
> Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> index 725d3bc3ee72..d6ae80414654 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> @@ -47,7 +47,6 @@ regulators-0 {
> vdd-bob2-supply = <&vph_pwr>;
> vdd-l2-l13-l14-supply = <&vreg_bob1>;
> vdd-l3-supply = <&vreg_s4g_1p3>;
> - vdd-l6-l16-supply = <&vreg_bob1>;
NACK.
There is actually an L6 but is not added yet.
But the correct one here is actually: vdd-l5-l16-supply
At least according to the power grid documentation.
> vdd-l6-l7-supply = <&vreg_bob1>;
> vdd-l8-l9-supply = <&vreg_bob1>;
> vdd-l11-supply = <&vreg_s4g_1p3>;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8550-mtp: drop incorrect vdd-l6-l16-supply
2023-01-27 11:34 ` Abel Vesa
@ 2023-01-27 11:38 ` Abel Vesa
2023-01-27 12:17 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2023-01-27 11:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, devicetree,
linux-kernel
On 23-01-27 13:34:03, Abel Vesa wrote:
> On 23-01-27 12:19:13, Krzysztof Kozlowski wrote:
> > There is no vdd-l6-l16 supply in qcom,pm8550-rpmh-regulators.
> >
> > Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> > index 725d3bc3ee72..d6ae80414654 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> > @@ -47,7 +47,6 @@ regulators-0 {
> > vdd-bob2-supply = <&vph_pwr>;
> > vdd-l2-l13-l14-supply = <&vreg_bob1>;
> > vdd-l3-supply = <&vreg_s4g_1p3>;
> > - vdd-l6-l16-supply = <&vreg_bob1>;
>
> NACK.
>
> There is actually an L6 but is not added yet.
Actually L6 is added already, my bad.
>
> But the correct one here is actually: vdd-l5-l16-supply
>
> At least according to the power grid documentation.
>
> > vdd-l6-l7-supply = <&vreg_bob1>;
> > vdd-l8-l9-supply = <&vreg_bob1>;
> > vdd-l11-supply = <&vreg_s4g_1p3>;
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8550-mtp: drop incorrect vdd-l6-l16-supply
2023-01-27 11:34 ` Abel Vesa
2023-01-27 11:38 ` Abel Vesa
@ 2023-01-27 12:17 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-27 12:17 UTC (permalink / raw)
To: Abel Vesa
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, devicetree,
linux-kernel
On 27/01/2023 12:34, Abel Vesa wrote:
> On 23-01-27 12:19:13, Krzysztof Kozlowski wrote:
>> There is no vdd-l6-l16 supply in qcom,pm8550-rpmh-regulators.
>>
>> Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>> index 725d3bc3ee72..d6ae80414654 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>> @@ -47,7 +47,6 @@ regulators-0 {
>> vdd-bob2-supply = <&vph_pwr>;
>> vdd-l2-l13-l14-supply = <&vreg_bob1>;
>> vdd-l3-supply = <&vreg_s4g_1p3>;
>> - vdd-l6-l16-supply = <&vreg_bob1>;
>
> NACK.
>
> There is actually an L6 but is not added yet.
>
> But the correct one here is actually: vdd-l5-l16-supply
Konrad also suggested this. I'll correct to l5-l16.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-27 12:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-27 11:19 [PATCH] arm64: dts: qcom: sm8550-mtp: drop incorrect vdd-l6-l16-supply Krzysztof Kozlowski
2023-01-27 11:23 ` Konrad Dybcio
2023-01-27 11:34 ` Abel Vesa
2023-01-27 11:38 ` Abel Vesa
2023-01-27 12:17 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox