From: Abel Vesa <abel.vesa@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8550-mtp: drop incorrect vdd-l6-l16-supply
Date: Fri, 27 Jan 2023 13:38:01 +0200 [thread overview]
Message-ID: <Y9O3mSkYJWMOWAjf@linaro.org> (raw)
In-Reply-To: <Y9O2q6Om+MK9k3UL@linaro.org>
On 23-01-27 13:34:03, Abel Vesa wrote:
> On 23-01-27 12:19:13, Krzysztof Kozlowski wrote:
> > There is no vdd-l6-l16 supply in qcom,pm8550-rpmh-regulators.
> >
> > Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> > index 725d3bc3ee72..d6ae80414654 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> > @@ -47,7 +47,6 @@ regulators-0 {
> > vdd-bob2-supply = <&vph_pwr>;
> > vdd-l2-l13-l14-supply = <&vreg_bob1>;
> > vdd-l3-supply = <&vreg_s4g_1p3>;
> > - vdd-l6-l16-supply = <&vreg_bob1>;
>
> NACK.
>
> There is actually an L6 but is not added yet.
Actually L6 is added already, my bad.
>
> But the correct one here is actually: vdd-l5-l16-supply
>
> At least according to the power grid documentation.
>
> > vdd-l6-l7-supply = <&vreg_bob1>;
> > vdd-l8-l9-supply = <&vreg_bob1>;
> > vdd-l11-supply = <&vreg_s4g_1p3>;
> > --
> > 2.34.1
> >
next prev parent reply other threads:[~2023-01-27 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 11:19 [PATCH] arm64: dts: qcom: sm8550-mtp: drop incorrect vdd-l6-l16-supply Krzysztof Kozlowski
2023-01-27 11:23 ` Konrad Dybcio
2023-01-27 11:34 ` Abel Vesa
2023-01-27 11:38 ` Abel Vesa [this message]
2023-01-27 12:17 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9O3mSkYJWMOWAjf@linaro.org \
--to=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox