From: Wolfram Sang <wsa@kernel.org>
To: Binbin Zhou <zhoubb.aaron@gmail.com>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
Andy Shevchenko <andy@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, loongarch@lists.linux.dev,
devicetree@vger.kernel.org, Huacai Chen <chenhuacai@loongson.cn>,
WANG Xuerui <kernel@xen0n.name>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jianmin Lv <lvjianmin@loongson.cn>,
Peibao Liu <liupeibao@loongson.cn>
Subject: Re: [PATCH V10 3/4] i2c: ls2x: Add driver for Loongson-2K/LS7A I2C controller
Date: Mon, 30 Jan 2023 10:14:56 +0100 [thread overview]
Message-ID: <Y9eKkBwuIR2okuXt@kunai> (raw)
In-Reply-To: <CAMpQs4LVc2nMR_ZxcqX_vOuyyyhip=fgEfYPqctJGy7YS89=Zg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
Hi,
> Sorry for the late reply.
No worries!
> Yes, I have tried this, and i2cdetect shows the following:
[...]
> Do you mean this?
Yes, very good!
> > > +subsys_initcall(ls2x_i2c_init_driver);
> >
> > Can't this be handled with deferred probing?
>
> Emm, I've been trying to register using the generic method before and
> deferred probing should be a better option.
> Also, I'll use module_platform_driver(ls2x_i2c_driver); instead in the
> next version.
Great, then the next version is likely to be the final one!
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-01-30 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 13:03 [PATCH V10 0/4] i2c: ls2x: Add support for the Loongson-2K/LS7A I2C controller Binbin Zhou
2023-01-10 13:03 ` [PATCH V10 1/4] i2c: gpio: Add support on ACPI-based system Binbin Zhou
2023-01-20 9:14 ` Wolfram Sang
2023-01-10 13:03 ` [PATCH V10 2/4] dt-bindings: i2c: Add Loongson LS2X I2C controller Binbin Zhou
2023-01-10 13:03 ` [PATCH V10 3/4] i2c: ls2x: Add driver for Loongson-2K/LS7A " Binbin Zhou
2023-01-20 9:08 ` Wolfram Sang
2023-01-30 8:52 ` Binbin Zhou
2023-01-30 9:14 ` Wolfram Sang [this message]
2023-01-10 13:04 ` [PATCH V10 4/4] LoongArch: Enable LS2X I2C in loongson3_defconfig Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9eKkBwuIR2okuXt@kunai \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=arnd@arndb.de \
--cc=chenhuacai@loongson.cn \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).