From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE38DC54EAA for ; Mon, 30 Jan 2023 18:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238310AbjA3Sgi (ORCPT ); Mon, 30 Jan 2023 13:36:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237642AbjA3Sgb (ORCPT ); Mon, 30 Jan 2023 13:36:31 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBADA8684 for ; Mon, 30 Jan 2023 10:35:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675103736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Lt1BSrHjqGxTuQATN1FHlMVFUULtc3t75DalFc1DJkQ=; b=fz5yxH4r+1zcsNy7z44xpI2WNdxoSQoDfDFDk4ZoIuQ0xyTMZubhBfWuw0Nqge9a+e16ys KXsU1GFv7HpWUuJIFOhbZNAKyr+RNuGMNVI1c/0YeCt/bitLRiD/R6hlOtALYu5Vo43Z0l 7AxtdG/NoAIMT3GnZvZ0+MwSKa0+65c= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-584-sxZQu0m5MtStFKdSVo72iA-1; Mon, 30 Jan 2023 13:35:35 -0500 X-MC-Unique: sxZQu0m5MtStFKdSVo72iA-1 Received: by mail-qt1-f200.google.com with SMTP id c16-20020ac85190000000b003b841d1118aso2434823qtn.17 for ; Mon, 30 Jan 2023 10:35:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lt1BSrHjqGxTuQATN1FHlMVFUULtc3t75DalFc1DJkQ=; b=rmvXK3imG7h5Y/hKmF0ix4+mebq2SuIjVO/9L1U8Fmacpm6GxhTfnykV4pF5Pq/g7E 2/1t88fDLOPEHP6ibvrePyyCrfahTg8NR6JwLh2vpPxyLsm8H+HXakEhN854QyNk4Veg 7AUKF0/E3kYCoknd9JdkyytBwPU0VO/4xoU1jWodKCxMtY243WLFgBTcaftAe0/pChmz +k0hQiETs3q1XAMidGMcRH6a+K7s/HfSCFWDwq7cgGo3K3xy8DOOdQqEtwN52N0EXie0 2UcKfq047oKGLlqVU/XP4ZJiemeuqHnRgmnXPfuVIb7b5l8qmRNbpZ+HRTmy/QAGW5bZ h86g== X-Gm-Message-State: AO0yUKUM6joFWWFmi5YrYH3OhdluCspIl5MT5Vi6Ar4iy8570q7I10BX Fl00vaSB1ViM7B6UJkvMzE6X2MwHXWhEYOAQcqKqpaWHblwCFMsdKIG5wlWNWFY1KATVy7wD+jj t7iuj2HXPdQFN5DUuBaxP3Q== X-Received: by 2002:a05:6214:5086:b0:537:7335:144f with SMTP id kk6-20020a056214508600b005377335144fmr33146792qvb.24.1675103734841; Mon, 30 Jan 2023 10:35:34 -0800 (PST) X-Google-Smtp-Source: AK7set/FPPbNpiUIaqVWHe+TRyIn3OsGXWnrIppmyHYJIz3KP+w5i9mRZLJBY8tMr/xBanz2UMPsXg== X-Received: by 2002:a05:6214:5086:b0:537:7335:144f with SMTP id kk6-20020a056214508600b005377335144fmr33146764qvb.24.1675103734613; Mon, 30 Jan 2023 10:35:34 -0800 (PST) Received: from x1 (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id o4-20020a05620a0d4400b006ea7f9d8644sm8448062qkl.96.2023.01.30.10.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 10:35:33 -0800 (PST) Date: Mon, 30 Jan 2023 13:35:32 -0500 From: Brian Masney To: Steev Klimaszewski Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Sven Peter , Balakrishna Godavarthi , Rocky Liao , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, Bjorn Andersson Subject: Re: [PATCH 3/4] arm64: dts: qcom: sc8280xp: Enable BT Message-ID: References: <20230129215136.5557-1-steev@kali.org> <20230129215136.5557-2-steev@kali.org> <20230129215136.5557-3-steev@kali.org> <20230129215136.5557-4-steev@kali.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230129215136.5557-4-steev@kali.org> User-Agent: Mutt/2.2.7 (2022-08-07) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Jan 29, 2023 at 03:51:29PM -0600, Steev Klimaszewski wrote: > From: Bjorn Andersson > > Signed-off-by: Bjorn Andersson You should also add your Signed-off-by. Also the title of the patch should be updated to say define uart2 instead of enable BT. > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 122afa03bb40..2d98687fb1ea 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -1244,6 +1244,20 @@ spi3: spi@98c000 { > status = "disabled"; > }; > > + uart2: serial@988000 { This node needs to go after spi2 instead of spi3. Everything else looks good to me. Brian