From: Lee Jones <lee@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: patchwork-bot+netdevbpf@kernel.org,
Colin Foster <colin.foster@in-advantage.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux@armlinux.org.uk,
richardcochran@gmail.com, f.fainelli@gmail.com, andrew@lunn.ch,
UNGLinuxDriver@microchip.com, alexandre.belloni@bootlin.com,
claudiu.manoil@nxp.com, vladimir.oltean@nxp.com,
pabeni@redhat.com, edumazet@google.com, davem@davemloft.net,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org
Subject: Re: [PATCH v5 net-next 00/13] add support for the the vsc7512 internal copper phys
Date: Wed, 1 Feb 2023 10:15:43 +0000 [thread overview]
Message-ID: <Y9o7z0Ddbwus0M1R@google.com> (raw)
In-Reply-To: <20230131114538.43e68eb3@kernel.org>
On Tue, 31 Jan 2023, Jakub Kicinski wrote:
> On Tue, 31 Jan 2023 09:06:22 +0000 Lee Jones wrote:
> > Please don't do that. The commits do not have proper Acked-by tags.
> >
> > The plan is to merge these via MFD and send out a pull-request to an
> > immutable branch. However, if you're prepared to convert all of the:
> >
> > Acked-for-MFD-by: Lee Jones <lee@kernel.org>
> >
> > to
> >
> > Acked-by: Lee Jones <lee@kernel.org>
>
> Sorry, I must have been blind yesterday because I definitely double
> checked this doesn't touch mfd code. And it does :/
>
> The patches should not be sent for net-next if they are not supposed
> to be applied directly. Or at the very least says something about
> merging in the cover letter!
>
> > ... and send out a pull request to a succinct (only these patches) and
> > immutable branch then that is also an acceptable solution.
> >
> > Please let me know what works best for you.
>
> Sorry for messing up again. Stable branch would obviously had been best.
> Do we have to take action now, or can we just wait for the trees to
> converge during the merge window?
Russell explained to me (off-list) that the net-next branch is immutable
and the only way to fix this would be to revert the whole set.
Let's not go to that much trouble this time.
It does mean that I cannot take any more commits on the affected files,
but that shouldn't be a big deal seeing how far into the release cycle
we are.
No real harm done.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-02-01 10:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 19:35 [PATCH v5 net-next 00/13] add support for the the vsc7512 internal copper phys Colin Foster
2023-01-27 19:35 ` [PATCH v5 net-next 01/13] net: mscc: ocelot: expose ocelot wm functions Colin Foster
2023-01-27 19:37 ` Florian Fainelli
2023-01-27 19:35 ` [PATCH v5 net-next 02/13] net: mscc: ocelot: expose regfield definition to be used by other drivers Colin Foster
2023-01-27 19:38 ` Florian Fainelli
2023-01-27 19:35 ` [PATCH v5 net-next 03/13] net: mscc: ocelot: expose vcap_props structure Colin Foster
2023-01-27 19:38 ` Florian Fainelli
2023-01-27 19:35 ` [PATCH v5 net-next 04/13] net: mscc: ocelot: expose ocelot_reset routine Colin Foster
2023-01-27 19:38 ` Florian Fainelli
2023-01-27 19:35 ` [PATCH v5 net-next 05/13] net: mscc: ocelot: expose vsc7514_regmap definition Colin Foster
2023-01-27 19:39 ` Florian Fainelli
2023-01-27 19:35 ` [PATCH v5 net-next 06/13] net: dsa: felix: add configurable device quirks Colin Foster
2023-01-27 19:39 ` Florian Fainelli
2023-01-27 19:35 ` [PATCH v5 net-next 07/13] net: dsa: felix: add support for MFD configurations Colin Foster
2023-01-27 19:40 ` Florian Fainelli
2023-01-27 19:35 ` [PATCH v5 net-next 08/13] net: dsa: felix: add functionality when not all ports are supported Colin Foster
2023-01-27 19:41 ` Florian Fainelli
2023-01-27 19:35 ` [PATCH v5 net-next 09/13] mfd: ocelot: prepend resource size macros to be 32-bit Colin Foster
2023-01-27 19:41 ` Florian Fainelli
2023-01-27 19:35 ` [PATCH v5 net-next 10/13] dt-bindings: net: mscc,vsc7514-switch: add dsa binding for the vsc7512 Colin Foster
2023-01-30 21:10 ` Rob Herring
2023-01-27 19:35 ` [PATCH v5 net-next 11/13] dt-bindings: mfd: ocelot: add ethernet-switch hardware support Colin Foster
2023-01-30 21:10 ` Rob Herring
2023-01-27 19:35 ` [PATCH v5 net-next 12/13] net: dsa: ocelot: add external ocelot switch control Colin Foster
2023-01-27 19:53 ` Florian Fainelli
2023-01-27 19:35 ` [PATCH v5 net-next 13/13] mfd: " Colin Foster
2023-01-27 19:53 ` Florian Fainelli
2023-01-27 20:15 ` Colin Foster
2023-01-30 15:31 ` [PATCH v5 net-next 00/13] add support for the the vsc7512 internal copper phys Vladimir Oltean
2023-01-31 5:20 ` patchwork-bot+netdevbpf
2023-01-31 9:06 ` Lee Jones
2023-01-31 19:45 ` Jakub Kicinski
2023-01-31 19:55 ` Colin Foster
2023-02-01 10:15 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9o7z0Ddbwus0M1R@google.com \
--to=lee@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patchwork-bot+netdevbpf@kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).