From: Brian Masney <bmasney@redhat.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH 05/14] arm64: dts: qcom: sc8280xp: correct TLMM gpio-ranges
Date: Thu, 2 Feb 2023 19:15:07 -0500 [thread overview]
Message-ID: <Y9xSCwgUxHDeppz7@x1> (raw)
In-Reply-To: <1319a973-26ae-8c11-d967-8720aaf894df@linaro.org>
On Fri, Feb 03, 2023 at 01:05:35AM +0100, Konrad Dybcio wrote:
> On 3.02.2023 00:59, Brian Masney wrote:
> > For others quick reference, Konrad is talking about this line from
> > sa8540p-ride.dts:
> >
> > reset-gpios = <&tlmm 228 GPIO_ACTIVE_LOW>;
> >
> > I noticed that earlier but assumed this was one based. However, looking
> > at pinctrl-sc8280xp.c I see gpio0..gpio227 defined.
>
> + gpio229 is the reset pin for the UFS card slot
We don't have the UFS card slot on the sa8540p exposed. However, it is
available on the sa8295p.
The original DTS in upstream listed 230 pins, however pinctrl-sc8280xp.c
lists 233 pins and the two UFS pins match what we have in DTS.
static const struct pinctrl_pin_desc sc8280xp_pins[] = {
PINCTRL_PIN(0, "GPIO_0"),
...
PINCTRL_PIN(227, "GPIO_227"),
PINCTRL_PIN(228, "UFS_RESET"),
PINCTRL_PIN(229, "UFS1_RESET"),
PINCTRL_PIN(230, "SDC2_CLK"),
PINCTRL_PIN(231, "SDC2_CMD"),
PINCTRL_PIN(232, "SDC2_DATA"),
Rescind-Reviewed-by: Brian Masney <bmasney@redhat.com>
next prev parent reply other threads:[~2023-02-03 0:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:50 [RFT PATCH 00/14] ARM/arm64: dts: qcom: correct TLMM gpio-ranges Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 01/14] ARM: dts: qcom: sdx55: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 02/14] ARM: dts: qcom: sdx65: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 03/14] arm64: dts: qcom: msm8953: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 04/14] arm64: dts: qcom: sc7180: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 05/14] arm64: dts: qcom: sc8280xp: " Krzysztof Kozlowski
2023-02-02 22:58 ` Brian Masney
2023-02-02 23:45 ` Konrad Dybcio
2023-02-02 23:59 ` Brian Masney
2023-02-03 0:05 ` Konrad Dybcio
2023-02-03 0:15 ` Brian Masney [this message]
2023-02-03 7:10 ` Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 06/14] arm64: dts: qcom: sdm670: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 07/14] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 08/14] arm64: dts: qcom: sm6115: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 09/14] arm64: dts: qcom: sm6125: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 10/14] arm64: dts: qcom: sm6350: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 11/14] arm64: dts: qcom: sm6375: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 12/14] arm64: dts: qcom: sm8150: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 13/14] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 14/14] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
2023-02-02 10:39 ` [RFT PATCH 00/14] ARM/arm64: dts: qcom: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9xSCwgUxHDeppz7@x1 \
--to=bmasney@redhat.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).