From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C095BC433E6 for ; Tue, 26 Jan 2021 04:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C9AA22DFB for ; Tue, 26 Jan 2021 04:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727418AbhAZEqc (ORCPT ); Mon, 25 Jan 2021 23:46:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730315AbhAYPpG (ORCPT ); Mon, 25 Jan 2021 10:45:06 -0500 Received: from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com [IPv6:2607:f8b0:4864:20::c2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3179C061353 for ; Mon, 25 Jan 2021 07:18:48 -0800 (PST) Received: by mail-oo1-xc2d.google.com with SMTP id y14so3333122oom.10 for ; Mon, 25 Jan 2021 07:18:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tqHsUUcTKe2jpNesKI4Ls70gHgXQSHomQormGTtd+iw=; b=imItcls200JtD5a68DthH3lsLf4uMZWQ91vTV4g7TYBg/St0bmxyqGgdbR2rjn+iIn 15IkSULWWDrZXcQisDmEKjoemcLL+w95s//mDlWuqpn1ypwxq18OsLoIHX0HT+7fnFBr gHfE+lEYIN24Q9D9WVpXPXNpVAUg4x06GLOOSCxEdKzQgDNUvqlA9INcdgIqp+3SN48t poqxp3XiVOn8u5prL2a86r9pykxuSIRUX6rqn25vYQ+ze2XDzkZIcwfhKgERUdL7a2RP i9m7zEA33fA7c7FxLWieFyPQBNFvXBOchQ0DN2rc1uL5FLu2bF83xmYA+emTYMDrPDHn 6Lug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tqHsUUcTKe2jpNesKI4Ls70gHgXQSHomQormGTtd+iw=; b=BJa5g+a+/iCeMDAJzdK/xRBmLWj8WwJgU2/oG9ZfVBnVUhKxSfGgqYNNN4mVseGirq oQXbhXL+tRLsgqx0wjfWinob7NQ480kfC9Z3/DgAIm/MYG2uvN+tfjwuJnEqb/bhtq0Y kV66dqOaTBSZe9f9bhexlhMF+ctUp7LZwfvlDaiLNPaivWaw7YED3WsmHUdW4RpFykje iHxxleAhSPLNYyCzK/G2/XdgZLUSw3DZps1IdpGDJHeXxX/ITnx4qN5UbhrjAjLgXZ7u nbZFxa/j4kCxsaojj8Nvq+HTEtqHa4ce0wSD1Ybf+FU2h/nhUCXMwEo0pTz1mhvlX3v3 uNRw== X-Gm-Message-State: AOAM5315JEZ91ZykjygXZMVdR9JZZpKIR2LKCEtRf+0kvyXrv2CglIbc tyWYpFQi3kwKE+NxfY/KtBAiLw== X-Google-Smtp-Source: ABdhPJxhWtj7ijUayPT4NSsxAYdvO1VOqHaRxL5y+7iV9e5hW3l/lC2sNftCU/43hxqEuvMuSgiwdQ== X-Received: by 2002:a05:6820:22c:: with SMTP id j12mr815447oob.65.1611587928383; Mon, 25 Jan 2021 07:18:48 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id m7sm3524169otq.33.2021.01.25.07.18.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 07:18:47 -0800 (PST) Date: Mon, 25 Jan 2021 09:18:45 -0600 From: Bjorn Andersson To: AngeloGioacchino Del Regno Cc: Hans Verkuil , Stanimir Varbanov , agross@kernel.org, mchehab@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, phone-devel@vger.kernel.org Subject: Re: [PATCH 1/2] media: venus: core: Add sdm660 DT compatible and resource struct Message-ID: References: <20210115185252.333562-1-angelogioacchino.delregno@somainline.org> <20210115185252.333562-2-angelogioacchino.delregno@somainline.org> <2dc8a95f-110f-526f-18a8-6393e508c3a6@linaro.org> <40c38734-a69d-2314-c342-244ee5a0e6b1@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40c38734-a69d-2314-c342-244ee5a0e6b1@somainline.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon 25 Jan 08:51 CST 2021, AngeloGioacchino Del Regno wrote: > Il 25/01/21 11:40, Hans Verkuil ha scritto: > > On 18/01/2021 18:45, AngeloGioacchino Del Regno wrote: > > > Il 18/01/21 18:21, Stanimir Varbanov ha scritto: > > > > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c [..] > > > > > + .fwname = "qcom/venus-4.4/venus.mdt", [..] > > This patch can't be merged unless there is a corresponding firmware available > > in linux-firmware. Is the current 4.2 firmware in linux-firmware signed by > > Qualcomm? Can they provided 4.4 firmware as well? > > > > If there is such issue, then maybe we should do "something" about it: I > would then propose to remove all references to fwname and just get this > done in DT, where every qcom board already specifies its own path for > its own firmware. > We have the same problem with production devices on e.g. SDM845, where the firmware referenced by fw_name and present in linux-firmware won't work on any real devices. As such, providing means for specifying the firmware name in DT would be a very reasonable thing, and in line with how we handle this in other subsystems (using the firmware-name property, containing the full relative path). Regards, Bjorn