From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5521AC433E6 for ; Fri, 15 Jan 2021 14:17:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 205FB23772 for ; Fri, 15 Jan 2021 14:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732264AbhAOORT (ORCPT ); Fri, 15 Jan 2021 09:17:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730480AbhAOORT (ORCPT ); Fri, 15 Jan 2021 09:17:19 -0500 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0876DC061794 for ; Fri, 15 Jan 2021 06:16:39 -0800 (PST) Received: by mail-oi1-x22a.google.com with SMTP id q205so9612321oig.13 for ; Fri, 15 Jan 2021 06:16:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xHR45BqFHfJv6MRdRPDoE4iFdlHt6oL+toEf1xWKDZA=; b=cbuuzmMVLKv9n8TGJd339eGVm4FcqTMDikQXx3IlQj12fUSPKdq+dKusZjF6QbWyfI tm4cLI9OY0i8wcoFCCbm0H/xMlLcCLXil6wd5omCEn22h5vOGsPadKhHZnErtCwo2+GW AS1Ckll3ozEuAMsSGH9BaVG8OaBcLa19CDjB7FXXfR2JAYIqWhvie+gd/6pEkDIDjABa eboI0DzO37riZRWRJnCPauCn/n3nwI2Kuf66WIZZGbHnanboE7riBgZuTU1ktieQD/Cn HP0Jo1n72C//V8InSPcCOF9O+rECvLZdrxLfo4GJ5sWRnUV3bY26H6mOdFay30xGaLUe C8bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xHR45BqFHfJv6MRdRPDoE4iFdlHt6oL+toEf1xWKDZA=; b=ZhwysqNlwBa2Jg7g5vLg+TGrwto0pFdB/kGv3/FixIbhZP9Dl+snm9PVZqrCgWp5vR TWd2oVGcI40nu98hONQOTGXx4uy1IPY4275rODtwqmqbAjEgWWEjzjxKnvkzkXX5BHzE Entq15zSVJwDK0aLlcVlb6QE3zSQwHHMw6yaWAoQI1WGxWFLdRjSBz+SpbDy6ckYJIWO /+KfikFFj1zjKHOzR0tURKuDRI5emAf2I6VYXRZtVYHvQXWL28S2SkMboCjPE9DGdpEH 3NsfeYZISPtHSiBkso/VbN0gQi+gzN1yHKUxnTthUsve7+ETSduecPBB85lotNZ30CRC jswA== X-Gm-Message-State: AOAM533WRWGlrsNZmMJUG3mPVqZY8OAW6HR0HMj8LgC6MjxfBf+aSqT2 u9izlEeukjMJKiBGb4bbzacWFg== X-Google-Smtp-Source: ABdhPJxDXfSziU5l3j+1xSDFWqiLhsDJUzsFLoMdrn3jJMVI/FFnjq+oJSffaPRo/doc/oi3dxILVA== X-Received: by 2002:aca:540e:: with SMTP id i14mr5716363oib.57.1610720198253; Fri, 15 Jan 2021 06:16:38 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id a18sm1805011otf.33.2021.01.15.06.16.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 06:16:37 -0800 (PST) Date: Fri, 15 Jan 2021 08:16:35 -0600 From: Bjorn Andersson To: Konrad Dybcio Cc: Caleb Connolly , Andy Gross , Rob Herring , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] arm64: dts: sdm845: add oneplus6/6t devices Message-ID: References: <20210114203057.64541-1-caleb@connolly.tech> <20210114203057.64541-2-caleb@connolly.tech> <061f8c37-533f-b694-f9a8-393cb9a34e01@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <061f8c37-533f-b694-f9a8-393cb9a34e01@somainline.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri 15 Jan 06:28 CST 2021, Konrad Dybcio wrote: > > Please move gpio-keys before reserved-memory to keep things sorted. > > > > + vreg_l25a_3p3: ldo25 { > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3312000>; > > + regulator-initial-mode = ; > > + }; > > + vdda_mipi_dsi0_1p2: > > > Add a newline between the "};" and "vdda_mipi_dsi0_1p2:" to keep it consistent. > Done and merged. > > After that, you can add: > > Reviewed-by: Konrad Dybcio > Thanks for the patch and the review! Regards, Bjorn