From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5341C43381 for ; Mon, 18 Jan 2021 20:31:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F15D22D2A for ; Mon, 18 Jan 2021 20:31:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388277AbhARUbG (ORCPT ); Mon, 18 Jan 2021 15:31:06 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:60292 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388985AbhARKkV (ORCPT ); Mon, 18 Jan 2021 05:40:21 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 592092BB; Mon, 18 Jan 2021 11:39:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1610966367; bh=TKLjavu6pPNWiWATpjYQ9nSe4YBqURvP+wFcE4ajSBU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SrN/sOIk8axDB8p/bdwJS70mQ5MSAc8xS7MJGuzT/fR7OzaWnPog84RvXn2WlwO9b sTwxsezGt4QqRe1GEi5cM9bFnzKHH9eeIj1C0pIUuL7ThfWPuWWnEwUbZ1c68HfaAg vKqAKFMqsYCKQh3yLNg6lH6szeTraXJDLJs5ps48= Date: Mon, 18 Jan 2021 12:39:11 +0200 From: Laurent Pinchart To: Chen-Yu Tsai Cc: Maxime Ripard , Rob Herring , Frank Rowand , devicetree , Jernej Skrabec , linux-arm-kernel , Laurent Pinchart , Sam Ravnborg Subject: Re: [PATCH 04/19] dt-bindings: bridge: simple: Add corpro,gm7123 compatible Message-ID: References: <20210114113538.1233933-1-maxime@cerno.tech> <20210114113538.1233933-4-maxime@cerno.tech> <20210118100321.ktbnfpsxka2icbaa@gilmour> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Chen-Yu, On Mon, Jan 18, 2021 at 06:22:15PM +0800, Chen-Yu Tsai wrote: > On Mon, Jan 18, 2021 at 6:03 PM Maxime Ripard wrote: > > On Fri, Jan 15, 2021 at 09:16:30AM +0200, Laurent Pinchart wrote: > > > On Thu, Jan 14, 2021 at 12:35:23PM +0100, Maxime Ripard wrote: > > > > The corpro,gm7123 was in use in a DT but was never properly documented, > > > > let's add it. > > > > > > > > Cc: Laurent Pinchart > > > > Cc: Sam Ravnborg > > > > Signed-off-by: Maxime Ripard > > > > --- > > > > .../devicetree/bindings/display/bridge/simple-bridge.yaml | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml > > > > index 64e8a1c24b40..97ca07b56cbc 100644 > > > > --- a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml > > > > +++ b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml > > > > @@ -22,6 +22,10 @@ properties: > > > > - ti,ths8134a > > > > - ti,ths8134b > > > > - const: ti,ths8134 > > > > + - items: > > > > + - const: corpro,gm7123 > > > > + - const: adi,adv7123 > > > > > > Do we need adi,adv7123 ? > > > > I'm not sure: it looks like having both the adv7123 and the dumb-vga-dac > > compatible was never an option, so we can also change the DT to have > > corpro,gm7123, dumb-vga-dac > > FYI I used the adi,adv7123 fallback because the gm7123 datasheet compares > the two, with the gm7123 having lower standby current, but only limited to > 3.3V power supply. Maximum resolution, conversion rate, and the range of > output current are all the same. The package is the same as well. I > believe the gm7123 is intended as a drop-in clone of the adv7123. That's a good point. I don't mind either way. Reviewed-by: Laurent Pinchart -- Regards, Laurent Pinchart