From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DC0C28B4B for ; Tue, 19 Jan 2021 18:29:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1516B22D2A for ; Tue, 19 Jan 2021 18:29:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392105AbhASR7o (ORCPT ); Tue, 19 Jan 2021 12:59:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731968AbhASR6Q (ORCPT ); Tue, 19 Jan 2021 12:58:16 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D4C6C061573; Tue, 19 Jan 2021 09:57:35 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id a9so17165213wrt.5; Tue, 19 Jan 2021 09:57:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cCuyHdaDKNdgvkGiCtIDRjNsTS1QMIkBB5jEcNPOBbc=; b=WbtKuRS1nA02ixu8TOLQZmxeJ3Q3Ib6SmpAjhjsqyxpJP8SpTApAmNuII3RhU59gQT HO1s26/ZYk8hn9946Y7LytYDSybdT3w4hcUKIHb54+I5XO8Gms4KfgmD+PW6x9m5E124 eUT4HK24tJWD4isorfUzWr7/XMAvOwNK38iMtNlf6IPczt/zLLIjoj3SqDv8YlfVfhyA +KTnTGFpHmN2uf3JkSP3zdFUKJuT0fwZ/fDQxnFEP/Y0E2z4VER1w0YQsOkWLmdS49Uj izNbb+ZygnZBWH05oGwO2lt9FlKKUcCnC68ONPUbXpWd+sLH70qS4Rb0Ih+6upKcJGLM D7Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cCuyHdaDKNdgvkGiCtIDRjNsTS1QMIkBB5jEcNPOBbc=; b=YJy756U1C5yM6jTzcWCxWA2edG/7fgUJnfeGDyc6CPRrNWSNgqqWbfeJRWXZmiWimM uuh/B7YPoMn2CgTydTDNu28saNtBageWPLSfntZX55dZ7vESZ234O1X02MSqOzw0GrQm RThUSs0Iq3rE+hQLXEIZ6FzXN1aScpsmanshyq+1I94YWfgepdVpNDdDQfq2TjY0spI+ +peeWBfcIQDJh4MpD7zVMZYYduC8OjEFq/GVyRj8EugxTWEZTfQJ7JfV9ome/9H7NCLP Y7Fmqn2W9lL9pIzu8NW5wPYFs11rBkcG/I1kfRlL8Mb3NbC2OSVmB01caNQQp1PvEEwn /o2A== X-Gm-Message-State: AOAM532vl2KZYXNW7ltcYXGy0xV4CpOORM/eozzHAo86sJb6z+zV2KGC bdIF8+IisDn+YAVYkkizGT0q161Y130= X-Google-Smtp-Source: ABdhPJxgji7Hd60FCvBKG6RsKh9xWB1ix7MRh3EgGDUFQRiug/el9Iqg2O8XkLOQpxAUQ288fVSi7w== X-Received: by 2002:adf:d1ce:: with SMTP id b14mr5422477wrd.329.1611079054086; Tue, 19 Jan 2021 09:57:34 -0800 (PST) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id t25sm5407477wmj.39.2021.01.19.09.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jan 2021 09:57:32 -0800 (PST) Date: Tue, 19 Jan 2021 18:57:31 +0100 From: Thierry Reding To: Sameer Pujar Cc: broonie@kernel.org, robh+dt@kernel.org, jonathanh@nvidia.com, kuninori.morimoto.gx@renesas.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, sharadg@nvidia.com Subject: Re: Re: [RESEND PATCH v6 5/6] arm64: tegra: Audio graph header for Tegra210 Message-ID: References: <1611048496-24650-1-git-send-email-spujar@nvidia.com> <1611048496-24650-6-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ef4HD4ePKjEwSwzf" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.4 (26f41dd1) (2020-12-30) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --ef4HD4ePKjEwSwzf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 19, 2021 at 11:09:32PM +0530, Sameer Pujar wrote: >=20 >=20 > On 1/19/2021 10:45 PM, Thierry Reding wrote: > > On Tue, Jan 19, 2021 at 02:58:15PM +0530, Sameer Pujar wrote: > > > Expose a header which describes DT bindings required to use audio-gra= ph > > > based sound card. All Tegra210 based platforms can include this header > > > and add platform specific information. Currently, from SoC point of v= iew, > > > all links are exposed for ADMAIF, AHUB, I2S and DMIC components. > > >=20 > > > Signed-off-by: Sameer Pujar > > > Reviewed-by: Jon Hunter > > > --- > > > .../boot/dts/nvidia/tegra210-audio-graph.dtsi | 153 ++++++++++= +++++++++++ > > > 1 file changed, 153 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-audio-graph.= dtsi > > I prefer keeping everything in tegra210.dtsi, but I can do that merge > > when I apply, after the DT bindings have been acked, so no need to > > resend just because of that. >=20 > I think this may be fine for Tegra210 based boards. But for Tegra186 and > Tegra194, whenever we add support for it, can rely on a common audio-graph > dtsi because there is no change w.r.t APE. This can help us to avoid > duplication of the bindings. This most likely applies to future chips as > well (where Tegra186 audio-graph bindings can be considered as base) when > there is no significant change in APE. Maybe. Although that argument is somewhat extreme because we already have some of that same duplication throughout the other .dtsi files. By the same argument we could save a bit of duplication by having something like tegra-gpio.dtsi and including that in all the SoC .dtsi files and only update the compatible string, because that's the only significant change. Duplication isn't a big problem for DTS files because the data is meant to be stable anyway. So once it is in place and doesn't have to change, it really doesn't matter if it comes from an include or it's duplicated. Thierry --ef4HD4ePKjEwSwzf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmAHHYsACgkQ3SOs138+ s6HzERAApo6U7ZDcY9jQ9XXohES6pX0zS0bRwPETSxyp1JYt4RWMgDn5fnfeYtkP InqVfiYYiqSbF46y4yBtVv5CcNJFu8+NRMmXhlgf3BLP7wMOQo1ZA+awS+Q8LX11 mIs2vuAnbyPZIaaU/+YiCpXjfu6Rb/+yLCZbCDkpy0E9BWh9q15Qo512HcEQTowh VrVSZLQfx7mWnAs0gDykKdnMghb/LCTtLsSLrJaS2Uh7LoY84L3sDHDIRqAVLgqu LyTPeb6cw+TH9YA9Vb1DbzXQiOl0fmb7ca1Fhglfd4oCoaSAh+Oti0m4TLkOlAwV 2mJi7iHCOCGZw4EdMKsWBRPSwtAv/jqqnYzF2sozC6+79Kitktf2LalH3HdiwgWr bcnPVKIYGNK8nvvllKSxnODb9dwBh5dvVERUTrPScTb+wtVkBJckbDHQ8KhQsmzO HrXD6f/DpgSjkacP9We0zwiud1toD0kr0b3BsD4n3CrKeGuJBtK/jDK2WcwIXX4O oNxxKIhnSr//KNI+29dxug6BJaBMt55r8gqVg+d/EZeufXFvyiCwQHJKyuNREQgf Ne0cj/tDFyHu2l5TG0ivO+fbnmqin7UBFxNnFP7ObwS61l1VuYE3SCNraT2WrDtz PX+ONBWVUg6Bc0/HRieI978DI5krbdHZjxOmgNKfeqrT3r+Sfc4= =ThIL -----END PGP SIGNATURE----- --ef4HD4ePKjEwSwzf--