From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72AC0C433DB for ; Thu, 21 Jan 2021 20:43:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C9EF2389F for ; Thu, 21 Jan 2021 20:43:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727525AbhAUUmw (ORCPT ); Thu, 21 Jan 2021 15:42:52 -0500 Received: from mga07.intel.com ([134.134.136.100]:44895 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727459AbhAUUmc (ORCPT ); Thu, 21 Jan 2021 15:42:32 -0500 IronPort-SDR: qrHyRx6+hj5fDanU5FnnpNj00RWHfpsXgXukbWNiZ+QERAMke/QyqEX39oXilcAQxubQ32qeeW w5fsBAisw6zQ== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="243416471" X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208";a="243416471" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 12:40:37 -0800 IronPort-SDR: Rr4DoKevT+g5dZ6hx/wrxwD3LZ+q52T4F7qD4my6qpHZrNVVOPwbSDuqjLIrLCj6ugxQ1kmQNQ g7OoXfoBK0Vw== X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208";a="351587401" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 12:40:34 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1l2gls-007zQL-NK; Thu, 21 Jan 2021 22:41:36 +0200 Date: Thu, 21 Jan 2021 22:41:36 +0200 From: Andy Shevchenko To: Bjorn Helgaas Cc: srikanth.thokala@intel.com, bhelgaas@google.com, robh+dt@kernel.org, lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, mgross@linux.intel.com, lakshmi.bai.raja.subramanian@intel.com, mallikarjunappa.sangannavar@intel.com Subject: Re: [PATCH v6 2/2] PCI: keembay: Add support for Intel Keem Bay Message-ID: References: <20210122032610.4958-3-srikanth.thokala@intel.com> <20210121195206.GA2678455@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121195206.GA2678455@bjorn-Precision-5520> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jan 21, 2021 at 01:52:06PM -0600, Bjorn Helgaas wrote: > On Fri, Jan 22, 2021 at 08:56:10AM +0530, srikanth.thokala@intel.com wrote: > > Signed-off-by: Wan Ahmad Zainie > > Signed-off-by: Srikanth Thokala This list seems strange. Shouldn't be your SoB last? ... > ... yep, all previous entries are in alphabetical > order. This new one just got dropped at the end. > > I feel like a broken record, but please, please, take a look at the > surrounding code/text/whatever, and MAKE YOUR NEW STUFF MATCH THE > EXISTING STYLE. We want the whole thing to be reasonably consistent > so readers can make sense of it without being confused by the > idiosyncrasies of every contributor. I guess even checkpatch.pl should complain about this these days. -- With Best Regards, Andy Shevchenko