From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] arm64: tegra: Add support for Jetson Xavier NX with eMMC
Date: Wed, 27 Jan 2021 19:31:45 +0100 [thread overview]
Message-ID: <YBGxkd1Ig5/2R0aG@ulmo> (raw)
In-Reply-To: <20210127175250.326390-1-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]
On Wed, Jan 27, 2021 at 05:52:50PM +0000, Jon Hunter wrote:
> There are two versions of the Jetson Xavier NX system-on-module; one
> with a micro SD-card slot and one with an eMMC. Currently, only the
> system-on-module with the micro SD-card slot is supported and so add
> necessary device-tree changes to add support for the eMMC version.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/Makefile | 1 +
> .../nvidia/tegra194-p3509-0000+p3668-0000.dts | 351 +-----------------
> .../nvidia/tegra194-p3509-0000+p3668-0001.dts | 10 +
> .../boot/dts/nvidia/tegra194-p3509-0000.dtsi | 351 ++++++++++++++++++
> .../boot/dts/nvidia/tegra194-p3668-0000.dtsi | 282 +-------------
> .../boot/dts/nvidia/tegra194-p3668-0001.dtsi | 19 +
> .../arm64/boot/dts/nvidia/tegra194-p3668.dtsi | 284 ++++++++++++++
> 7 files changed, 669 insertions(+), 629 deletions(-)
> create mode 100644 arch/arm64/boot/dts/nvidia/tegra194-p3509-0000+p3668-0001.dts
> create mode 100644 arch/arm64/boot/dts/nvidia/tegra194-p3509-0000.dtsi
> create mode 100644 arch/arm64/boot/dts/nvidia/tegra194-p3668-0001.dtsi
> create mode 100644 arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi
This looks good, although I must say this is difficult to review. Maybe
it would help if this was split into two patches where first the files
are split for tegra194-p3509-0000+p3668-0000 and the second patch adds
only the files for the new SKU.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-27 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 17:52 [PATCH] arm64: tegra: Add support for Jetson Xavier NX with eMMC Jon Hunter
2021-01-27 18:31 ` Thierry Reding [this message]
2021-01-27 19:30 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBGxkd1Ig5/2R0aG@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox