devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 2/2] dt-bindings: display: Add "disable-hpd" binding
       [not found] <20210131095701.965147-1-ddone@aruko.org>
@ 2021-02-08  9:18 ` Neil Armstrong
  2021-02-09  0:55 ` Laurent Pinchart
  1 sibling, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2021-02-08  9:18 UTC (permalink / raw)
  To: Mykyta Poturai
  Cc: devicetree, David Airlie, Kieran Bingham, linux-kernel, dri-devel,
	linux-renesas-soc, Rob Herring, Laurent Pinchart

Hi,

On 31/01/2021 10:57, Mykyta Poturai wrote:
> Add the "disable-hpd" binding, used to disable hotplug detected
> functionality in the driver. When it's enabled the driver assumes that
> the connector is always connected and disables the hotplug detect
> related IRQ.

DT describes the hardware, not the software behaviour.

So if the HPD is broken, then add a "snps,broken-hpd" instead, or if you want to force output, use the DRM mode forcing, which is handled by the dw-hdmi code:
https://wiki.archlinux.org/index.php/kernel_mode_setting#Forcing_modes

Neil

> 
> Signed-off-by: Mykyta Poturai <ddone@aruko.org>
> ---
>  .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt       | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> index 3f6072651182..b2b899f46b86 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> @@ -39,6 +39,7 @@ Optional properties:
>  
>  - power-domains: Shall reference the power domain that contains the DWC HDMI,
>    if any.
> +- disable-hpd: Disables the hotplug detect feature
>  
>  
>  Example:
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] dt-bindings: display: Add "disable-hpd" binding
       [not found] <20210131095701.965147-1-ddone@aruko.org>
  2021-02-08  9:18 ` [PATCH 2/2] dt-bindings: display: Add "disable-hpd" binding Neil Armstrong
@ 2021-02-09  0:55 ` Laurent Pinchart
  1 sibling, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2021-02-09  0:55 UTC (permalink / raw)
  To: Mykyta Poturai
  Cc: devicetree, David Airlie, Kieran Bingham, linux-kernel, dri-devel,
	linux-renesas-soc, Rob Herring

Hi Mykyta,

Thank you for the patch.

On Sun, Jan 31, 2021 at 11:57:01AM +0200, Mykyta Poturai wrote:
> Add the "disable-hpd" binding, used to disable hotplug detected
> functionality in the driver. When it's enabled the driver assumes that
> the connector is always connected and disables the hotplug detect
> related IRQ.
> 
> Signed-off-by: Mykyta Poturai <ddone@aruko.org>
> ---
>  .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt       | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> index 3f6072651182..b2b899f46b86 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> @@ -39,6 +39,7 @@ Optional properties:
>  
>  - power-domains: Shall reference the power domain that contains the DWC HDMI,
>    if any.
> +- disable-hpd: Disables the hotplug detect feature

A similar property has been added to the ti,sn65dsi86 bindings in commit
1dbc979172af ("dt-bindings: drm/bridge: ti-sn65dsi86: Document no-hpd").
A property with the same name exists in panel-common.yaml. Could we
standardize on that name ?

The description should also explain the hardware architecture, not the
driver behaviour. This is what the ti,sn65dsi86 binding documents:

  no-hpd:
    type: boolean
    description:
      Set if the HPD line on the bridge isn't hooked up to anything or is
      otherwise unusable.

You could use the same description, assuming this is the use case you
want to support. Could you perhaps describe your problem in a bit more
details ? Do you have a system with an HDMI panel that is always
connected, with the HPD signal of the dw-hdmi not connected ?

>  Example:

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-09  0:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20210131095701.965147-1-ddone@aruko.org>
2021-02-08  9:18 ` [PATCH 2/2] dt-bindings: display: Add "disable-hpd" binding Neil Armstrong
2021-02-09  0:55 ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).