From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3114CC433DB for ; Tue, 9 Feb 2021 20:02:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D642F64DEE for ; Tue, 9 Feb 2021 20:02:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233726AbhBIUBB (ORCPT ); Tue, 9 Feb 2021 15:01:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233766AbhBITwA (ORCPT ); Tue, 9 Feb 2021 14:52:00 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C708C061356; Tue, 9 Feb 2021 11:19:30 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id v15so23410368wrx.4; Tue, 09 Feb 2021 11:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LdU37lNhDGvGGmXAMcE5ydz9bMREEufjvwEN8UDTB/4=; b=F9+10W24LAFXpvtC9BL+mfIHewjZBcP0gr3jPY+B3GxCXvErXX9JiZ89eAeRvVT88j MSdIvVacH6Ey24JDVhh3g9VuZo0GK3Lej8iw9VhCrbulPcbn8CWXkHcSfkpkAEWrV/5c p6yuTREOGZZEXrDWVcBaZ3lzq4WZ+S/M6MCTnvsSUosBLYMi5/3UWYKuQTntOrmdDdRT V89lpTsbryFNMclIBLuvR1xLKQoV7+fl1IduR6MrvMcZZVI7Sf42DP7nce3EplemuuYR WIkB3D8WmWOd4woXFuOGQe3iaOvl6w8e9eEJfCMfFeZQmG29G2ji9ols/F1SsmLc2swk uKPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LdU37lNhDGvGGmXAMcE5ydz9bMREEufjvwEN8UDTB/4=; b=Hheiza1ymQrW3JYzK9DPMlOr88Pa+5t+gXrAsbxfeq2xnQUctN5bWpIcSQWBbqFxk7 Ra2W7W9x2U+PzntE/mDjHZcGCnL4S5oVtqnthAyapXZMjrdnNBAivRfDgTppTK18d+C1 ffGfwxpQ/MgkoQ4tFNcCtxQ72GcMdO+7Io4ueVI8wYGJiqCw0X4cwaaRRuB/4lGpkqdW avhQ5qpL1AYXUJK/I0Aj6l5KJ0AZ/efjffc6ErqU0ReHB3a8GFipW02W/lOQNYx5VGdF 0lI5ZnFktZ/q8t29uYv6b4/vhyhQpIud5Ym59VUgVOGplrejq0JAjcdBGseG8u5tTl7W nkkw== X-Gm-Message-State: AOAM532M5mtBd6rrvSHQ6rBhgp/4bn1cvSDVheSeghhWbRiqELBAojKJ +CJRDYoDCnQNq3pmW5iJa3Y= X-Google-Smtp-Source: ABdhPJzy2FifsRzBzoPISrOA7c9EjqQOP4MTXtKqAd6gCGSsmhvjzZRRGtnkgeiObYjQeDD5t2IZlA== X-Received: by 2002:a5d:6b87:: with SMTP id n7mr14503619wrx.222.1612898369075; Tue, 09 Feb 2021 11:19:29 -0800 (PST) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id l2sm5622864wmq.17.2021.02.09.11.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 11:19:27 -0800 (PST) Date: Tue, 9 Feb 2021 20:19:24 +0100 From: Thierry Reding To: Sameer Pujar Cc: Rob Herring , broonie@kernel.org, lgirdwood@gmail.com, kuninori.morimoto.gx@renesas.com, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, sharadg@nvidia.com, Oder Chiou , Bard Liao Subject: Re: [PATCH v2 1/9] ASoC: dt-bindings: rt5659: Update binding doc Message-ID: References: <1611944866-29373-1-git-send-email-spujar@nvidia.com> <1611944866-29373-2-git-send-email-spujar@nvidia.com> <20210205152933.GA3089668@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fE2lUxibOs/cNBX0" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (da5e3282) (2021-01-21) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --fE2lUxibOs/cNBX0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 09, 2021 at 06:51:58PM +0530, Sameer Pujar wrote: > Hi Rob, >=20 > On 2/5/2021 8:59 PM, Rob Herring wrote: > > External email: Use caution opening links or attachments > >=20 > >=20 > > On Fri, Jan 29, 2021 at 11:57:38PM +0530, Sameer Pujar wrote: > > > Update following in rt5659.txt binding doc > > > - Add JD source for Intel HDA header: Commit 041e74b71491 > > > ("ASoC: rt5659: Add the support of Intel HDA Header") > > > added driver support. Add missing info here. > > >=20 > > > - sound-name-prefix: Used to prefix component widgets/kcontrols > > > with given prefix. > > >=20 > > > - ports: Helps to use the Codec with audio graph card > > >=20 > > > Signed-off-by: Sameer Pujar > > > Reported-by: Jon Hunter > > > Cc: Oder Chiou > > > Cc: Bard Liao > > > --- > > > Documentation/devicetree/bindings/sound/rt5659.txt | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/sound/rt5659.txt b/Doc= umentation/devicetree/bindings/sound/rt5659.txt > > > index 56788f5..c473df5 100644 > > > --- a/Documentation/devicetree/bindings/sound/rt5659.txt > > > +++ b/Documentation/devicetree/bindings/sound/rt5659.txt > > > @@ -37,10 +37,21 @@ Optional properties: > > > - realtek,jd-src > > > 0: No JD is used > > > 1: using JD3 as JD source > > > + 2: JD source for Intel HDA header > > >=20 > > > - realtek,ldo1-en-gpios : The GPIO that controls the CODEC's LDO1_E= N pin. > > > - realtek,reset-gpios : The GPIO that controls the CODEC's RESET pi= n. > > >=20 > > > +- sound-name-prefix: Please refer to name-prefix.txt > > > + > > > +- ports: A Codec may have a single or multiple I2S interfaces. These > > > + interfaces on Codec side can be described under 'ports' or 'port'. > > > + When the SoC or host device is connected to multiple interfaces of > > > + the Codec, the connectivity can be described using 'ports' propert= y. > > > + If a single interface is used, then 'port' can be used. The usage > > > + depends on the platform or board design. > > > + Please refer to Documentation/devicetree/bindings/graph.txt > > Please read what that file says now. >=20 > Sorry, I did not understand above comment. Can you please elaborate a bit > more? I think what Rob meant to point out is that graph.txt now contains a mention that the file has been moved to a more central location, which is the dt-schema repository. So instead of referencing the graph.txt, which then redirects to the graph.yaml in dt-schema, it'd be better to directly reference graph.yaml from dt-schema. That said, I'm not aware of a good or standard way to make such a reference. Perhaps in this case, given that the rt5659 binding is not very large, you can convert the file to json-schema first and then use standard json-schema references for this. Thierry --fE2lUxibOs/cNBX0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmAi4DkACgkQ3SOs138+ s6EVCQ/8CB7rS0lCIaO/YUrcXFEY2TLSIUnu3FGjHYkt5fALU7w9Rt8uYVlfcoCF Htg0LXUqYXUd/zXjE+x1ymwx3Azrb9z7DVAnAcXrB2Nq4x5QkvKmjJN90P6K+Jw4 wI30K01fotkcbybxSX9wIIrRhhcSOd/JN0eExv/llHDz2jonCidB43TGd3p+hl71 aJ0MMMmew8mK5hD+hxOL/3eYbmiPVtgJCstonPWTDUOaq7+Mc7Sdk+Rt2XAHw+5D z1oZTbfjo7QQ9UN4JeXQPwv7PEWoAqCV5vEOFTdfljV7s88VhxkBmUWDP76ITJCH NL1fU9xRMwVtkN7CrS5/NUBQaOPVsXFYb2cqxHsosakvB/rpDDkWeFrUustar6n3 P4IspAPdOaeCTL+NzjxhL4Ij+W8xiialaTd1MGZsxdYPkX97+2onmXgUoQ10i8d+ F0gFWrSM7dMSigKgHId1hRKm2ZJrQXNQONDg+NwN5cX6AOFy9At8RFaFNBbzWRu1 Sq1n63PDPrHmcWpxy8H53n4Ce1UBNG4ZXDxzc1E91eNXMbdDe3ge/iomFIT1TiQr QWArTZk333ic4CuPH67hQFLhe83jWFJZRMLjAeGBJYq6Ff6Q6IcQbKh66CZ75/nV LfNAwaVzddpbaG0wMNxF1xCUDcQypRwkgQ2vgSFHjxua+65X6H0= =kZ90 -----END PGP SIGNATURE----- --fE2lUxibOs/cNBX0--