From: "Krzysztof Wilczyński" <kw@linux.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Tom Joseph <tjoseph@cadence.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector
Date: Mon, 22 Feb 2021 18:29:09 +0100 [thread overview]
Message-ID: <YDPp5VS120Cc79ey@rocinante> (raw)
In-Reply-To: <20210222114030.26445-2-kishon@ti.com>
Hi Kishon,
[...]
> clocks:
> - maxItems: 1
> - description: clock-specifier to represent input to the PCIe
> + minItems: 1
> + maxItems: 2
> + description: clock-specifier to represent input to the PCIe for 1 item.
> + 2nd item if present represents reference clock to the connector.
[...]
I am not an expert on device trees, but what do you think of making this
description to be as follows:
description: |+
clock-specifier to represent input to the PCIe for 1 item.
2nd item if present represents reference clock to the connector.
What do you think?
Krzysztof
next prev parent reply other threads:[~2021-02-22 17:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 11:40 [PATCH v3 0/4] AM64: Add PCIe bindings and driver support Kishon Vijay Abraham I
2021-02-22 11:40 ` [PATCH v3 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector Kishon Vijay Abraham I
2021-02-22 17:29 ` Krzysztof Wilczyński [this message]
2021-02-22 11:40 ` [PATCH v3 2/4] dt-bindings: PCI: ti,j721e: Add host mode dt-bindings for TI's AM64 SoC Kishon Vijay Abraham I
2021-03-05 23:28 ` [PATCH v3 2/4] dt-bindings: PCI: ti, j721e: " Rob Herring
2021-02-22 11:40 ` [PATCH v3 3/4] dt-bindings: PCI: ti,j721e: Add endpoint " Kishon Vijay Abraham I
2021-03-05 23:29 ` [PATCH v3 3/4] dt-bindings: PCI: ti, j721e: " Rob Herring
2021-02-22 11:40 ` [PATCH v3 4/4] PCI: j721e: Add support to provide refclk to PCIe connector Kishon Vijay Abraham I
2021-02-23 7:50 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDPp5VS120Cc79ey@rocinante \
--to=kw@linux.com \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh+dt@kernel.org \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).