From: Matthias Kaehlcke <mka@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: qcom: sc7180: Add lazor rev4
Date: Mon, 22 Feb 2021 15:41:58 -0800 [thread overview]
Message-ID: <YDRBRuUkrxCrLSeX@google.com> (raw)
In-Reply-To: <CAD=FV=Vcsu1JREUgtEH1zXB7Ph8QWWYMVO2ioqqVYj9Dd79JDg@mail.gmail.com>
On Mon, Feb 22, 2021 at 03:20:53PM -0800, Doug Anderson wrote:
> Hi,
>
> On Fri, Feb 19, 2021 at 6:11 PM Matthias Kaehlcke <mka@chromium.org> wrote:
> >
> > Lazor rev3 and older are stuffed with a 47k NTC thermistor for the
> > charger temperature which currently isn't supported by the PM6150 ADC
> > driver. A supported thermistor is used in rev4 and later revisions.
> > Add rev4 .dts files to be able to account for this.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> >
> > arch/arm64/boot/dts/qcom/Makefile | 3 ++
> > .../dts/qcom/sc7180-trogdor-lazor-r3-kb.dts | 4 +--
> > .../dts/qcom/sc7180-trogdor-lazor-r3-lte.dts | 4 +--
> > .../boot/dts/qcom/sc7180-trogdor-lazor-r3.dts | 4 +--
> > .../dts/qcom/sc7180-trogdor-lazor-r4-kb.dts | 20 +++++++++++++
> > .../dts/qcom/sc7180-trogdor-lazor-r4-lte.dts | 28 +++++++++++++++++++
> > .../boot/dts/qcom/sc7180-trogdor-lazor-r4.dts | 16 +++++++++++
> > 7 files changed, 73 insertions(+), 6 deletions(-)
>
> From what I can see in the latest discussions -r4 _won't_ get stuffed
> with the 100K resistor. Thus we can just treat -r4 as the same as all
> the other revisoins now, right?
Yes, looks like there is not need for an explicit -r4 after all.
prev parent reply other threads:[~2021-02-22 23:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 2:10 [PATCH 1/3] arm64: dts: qcom: sc7180: Add lazor rev4 Matthias Kaehlcke
2021-02-20 2:10 ` [PATCH 2/3] arm64: dts: qcom: sc7180: trogdor: Add labels to charger thermal zone and ADC channel Matthias Kaehlcke
2021-02-22 23:25 ` Doug Anderson
2021-02-20 2:10 ` [PATCH 3/3] arm64: dts: qcom: sc7180: Delete charger thermal zone and ADC channel for lazor <= rev3 Matthias Kaehlcke
2021-02-22 20:20 ` Stephen Boyd
2021-02-22 20:38 ` Matthias Kaehlcke
2021-02-22 20:45 ` Stephen Boyd
2021-02-22 23:25 ` Doug Anderson
2021-02-24 17:12 ` Matthias Kaehlcke
2021-02-23 11:12 ` Dmitry Baryshkov
2021-02-24 16:54 ` Matthias Kaehlcke
2021-02-22 23:20 ` [PATCH 1/3] arm64: dts: qcom: sc7180: Add lazor rev4 Doug Anderson
2021-02-22 23:41 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDRBRuUkrxCrLSeX@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).