From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17503C43219 for ; Wed, 24 Feb 2021 14:19:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7E0D64E7A for ; Wed, 24 Feb 2021 14:19:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236530AbhBXOTc (ORCPT ); Wed, 24 Feb 2021 09:19:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236322AbhBXNPI (ORCPT ); Wed, 24 Feb 2021 08:15:08 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 398AAC06174A; Wed, 24 Feb 2021 05:14:28 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BDBA458E; Wed, 24 Feb 2021 14:14:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1614172465; bh=5FXg3ZYXDanK+M7xH1Qmkj8gXTqz8/OnTRQgAeNfW2Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hU2/MagZgvIYux/Xw2guJ5BlJ5D2B+ivuZG0+CxwcvPCbiJcP97o9sgx8z3Lc1upT iyXcYuxqzF+VDqUYCkapI2t0ol7dm86zOuiZ0QO6BJ2se8xZNMp/xn2Mq71lTV4bRt SgZ9DEEN/RaDUcasAhA6CbI70hNVt1VH2lK+oGnk= Date: Wed, 24 Feb 2021 15:13:57 +0200 From: Laurent Pinchart To: Jagan Teki Cc: Rob Herring , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , dri-devel , linux-kernel , devicetree , linux-amarula Subject: Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211 Message-ID: References: <20210214175211.105107-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Jagan, On Wed, Feb 24, 2021 at 06:07:43PM +0530, Jagan Teki wrote: > On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote: > > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > > > It has a flexible configuration of MIPI DSI signal input and > > > produce RGB565, RGB666, RGB888 output format. > > > > > > Add dt-bingings for it. > > > > > > Signed-off-by: Jagan Teki > > > --- > > > Changes for v3: > > > - updated to new dt-bindings style > > > > > > .../display/bridge/chipone,icn6211.yaml | 90 +++++++++++++++++++ > > > 1 file changed, 90 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > new file mode 100644 > > > index 000000000000..13764f13fe46 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > @@ -0,0 +1,90 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > > > + > > > +maintainers: > > > + - Jagan Teki > > > + > > > +description: | > > > + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. > > > + > > > + It has a flexible configuration of MIPI DSI signal input and > > > + produce RGB565, RGB666, RGB888 output format. > > > > How does one select between the output formats ? Should the output > > connection option be described in the device tree ? > > I think that is a good option to select output formats via dts. what > if it makes it a generic property like data-lanes? since it is common > across many other bridges. Describing the output connection in the device tree sounds like a good idea indeed. The bus-width property could be used for this, maybe along the lines of https://lore.kernel.org/dri-devel/20201013020619.GG3942@pendragon.ideasonboard.com/. If, for a given wiring of the output, different formats could be used, then we would need to select them at runtime. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - chipone,icn6211 > > > + > > > + reg: > > > + maxItems: 1 > > > + description: virtual channel number of a DSI peripheral > > > + > > > + reset-gpios: > > > + description: GPIO connected for the reset pin > > > + > > > + ports: > > > + $ref: /schemas/graph.yaml#/properties/ports > > > + > > > + properties: > > > + port@0: > > > + $ref: /schemas/graph.yaml#/properties/port > > > + description: > > > + Video port for MIPI DSI input > > > + > > > + port@1: > > > + $ref: /schemas/graph.yaml#/properties/port > > > + description: > > > + Video port for MIPI DPI output (panel or connector). > > > + > > > + required: > > > + - port@0 > > > + - port@1 > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - reset-gpios > > > + - ports > > > > How about regulators ? > > Will add it in the next version. -- Regards, Laurent Pinchart