From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FA18C433DB for ; Mon, 8 Mar 2021 12:52:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0073D651FF for ; Mon, 8 Mar 2021 12:52:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229965AbhCHMvd (ORCPT ); Mon, 8 Mar 2021 07:51:33 -0500 Received: from muru.com ([72.249.23.125]:40832 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229754AbhCHMvZ (ORCPT ); Mon, 8 Mar 2021 07:51:25 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 93F7A80D4; Mon, 8 Mar 2021 12:52:05 +0000 (UTC) Date: Mon, 8 Mar 2021 14:51:20 +0200 From: Tony Lindgren To: linux-omap@vger.kernel.org Cc: =?utf-8?Q?Beno=C3=AEt?= Cousson , devicetree@vger.kernel.org, Bjorn Helgaas , Kishon Vijay Abraham I , Lorenzo Pieralisi , Vignesh Raghavendra , linux-pci@vger.kernel.org Subject: Re: [PATCH 09/15] ARM: dts: Configure interconnect target module for dra7 dmm Message-ID: References: <20210126124004.52550-1-tony@atomide.com> <20210126124004.52550-10-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126124004.52550-10-tony@atomide.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * Tony Lindgren [210126 12:43]: > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi ... > + target-module@4e000000 { > + compatible = "ti,sysc-omap2", "ti,sysc"; > ti,hwmods = "dmm"; > + reg = <0x4e000000 0x4>, > + <0x4e000010 0x4>; > + reg-names = "rev", "sysc"; > + ti,sysc-sidle = , > + , > + ; > + ranges = <0x0 0x4e000000 0x2000000>; > + #size-cells = <1>; > + #address-cells = <1>; > + > + dmm@0 { > + compatible = "ti,omap5-dmm"; > + reg = <0x4e000000 0x800>; > + interrupts = ; > + }; > }; The dmm@0 reg property above should be zero instead of 0x4e000000 now that we're using ranges. Looks like I did not test with omapdrm loaded earlier, updated patch below. Regards, Tony 8< --------------------------- >From tony Mon Sep 17 00:00:00 2001 From: Tony Lindgren Date: Mon, 8 Mar 2021 14:22:49 +0200 Subject: [PATCH] ARM: dts: Configure interconnect target module for dra7 dmm We can now probe devices with device tree only configuration using ti-sysc interconnect target module driver. Let's configure the module, but keep the legacy "ti,hwmods" peroperty to avoid new boot time warnings. The legacy property will be removed in later patches together with the legacy platform data. Tested-by: Kishon Vijay Abraham I Signed-off-by: Tony Lindgren --- arch/arm/boot/dts/dra7.dtsi | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi @@ -464,11 +464,24 @@ edma_tptc1: dma@0 { }; }; - dmm@4e000000 { - compatible = "ti,omap5-dmm"; - reg = <0x4e000000 0x800>; - interrupts = ; + target-module@4e000000 { + compatible = "ti,sysc-omap2", "ti,sysc"; ti,hwmods = "dmm"; + reg = <0x4e000000 0x4>, + <0x4e000010 0x4>; + reg-names = "rev", "sysc"; + ti,sysc-sidle = , + , + ; + ranges = <0x0 0x4e000000 0x2000000>; + #size-cells = <1>; + #address-cells = <1>; + + dmm@0 { + compatible = "ti,omap5-dmm"; + reg = <0 0x800>; + interrupts = ; + }; }; ipu1: ipu@58820000 { -- 2.30.1