From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CFD1C433E0 for ; Thu, 11 Mar 2021 00:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E031764FC8 for ; Thu, 11 Mar 2021 00:10:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230410AbhCKAKM (ORCPT ); Wed, 10 Mar 2021 19:10:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230143AbhCKAKG (ORCPT ); Wed, 10 Mar 2021 19:10:06 -0500 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 923D1C061574 for ; Wed, 10 Mar 2021 16:10:06 -0800 (PST) Received: by mail-oi1-x236.google.com with SMTP id x78so21239395oix.1 for ; Wed, 10 Mar 2021 16:10:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5oYluSsE5PgMAKZ6OcpTYiQImPVjA/JRZBOqfxdZrMk=; b=pqi2kCbDuS85FYifp5gs9DTNbdngCBmFP3e89PGjWiEK7oabYVmuRgqrnN15PPRJ0X zBkRQF0wHqqVGJWrxzdL0FV9TMwzCBe1UHGVPSsPQA0F4/MGQC0ewpiPZcPN0XWVURGT cS00sU/nRfPBUm2uXXzBD53OJwNgSfG7j2SlBgO5/kUYnA1xevXv/SuFhW+AwMNMfhQS AiRkgh9mqD+AGBTuKFCGxMka06k0N3mxlBa+8WeJg5aEHQ2OD7L9RWaZDAWAeuxLpjN8 ywq3iDnBuDnjZlmwzN83QPmLAINi1qRJCd/pzPmGnvYd4a0Th+KXf2T/5I91vO1rhWL5 XcGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5oYluSsE5PgMAKZ6OcpTYiQImPVjA/JRZBOqfxdZrMk=; b=Wjf8eJZ+j5U421jdncRr9Q/u29XV1K8a35jDPjuGL5Wjyzhq8Zl7Ro73FNtvAHUWNp qbYvBQ8uraBBXT5VWx3Nhy2Fmv8VA3dFiE0BiwtCP4JIzoS87LPGhV88IxYOxTfM80dG eS7baAxhLJWKKlhXW6lX6BRyLWat7dxoqJ7vxm44aDC99dya/y6gyOfhDGNfSlhxt4Mh jLD9iTCMojL0b4yCyH/ehOwvsQMoDlDY9o+QgTuqbLDF2zVQT2G4k6mD+q4f4BpdH9SB OangyNRB+03eUOUTq4LYUu1/ln5p8b6taIjAnew5Qn8ttyFNqXxaEhgEwFfgV07XH2KZ dXfA== X-Gm-Message-State: AOAM5317eWHK03bgKE0y08qAAJtzqlTCPHinVbOFrQm8ggRJ0ny3cL6D AsIF0UpCj6Kaspu5dYcGQ0U+fQ== X-Google-Smtp-Source: ABdhPJzBye2+8MGYrslJiA1IxeynpPjkr+OCDSlyqqFocWcvHwDX9tjEqB1+bEx4u7Fji3vQ3w3cfA== X-Received: by 2002:aca:f13:: with SMTP id 19mr4169811oip.56.1615421405962; Wed, 10 Mar 2021 16:10:05 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id n12sm275665otq.42.2021.03.10.16.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 16:10:05 -0800 (PST) Date: Wed, 10 Mar 2021 18:10:03 -0600 From: Bjorn Andersson To: Dmitry Baryshkov Cc: Jonathan Marek , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Andy Gross , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sm8250: fix display nodes Message-ID: References: <20210215162607.21360-1-jonathan@marek.ca> <20210215162607.21360-3-jonathan@marek.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue 16 Feb 15:14 CST 2021, Dmitry Baryshkov wrote: > Except for the compatible value changes: > > Reviewed-by: Dmitry Baryshkov > > May I suggest to split the compatibility name changes into a separate > series from this patch (without it the patch stands a chance of being > accepted into the stable tree, if I'm not mistaken). > Please let me know what I should do with this patch. Regards, Bjorn > On Mon, 15 Feb 2021 at 19:27, Jonathan Marek wrote: > > > > Apply these fixes to the newly added sm8250 display ndoes > > - Use sm8250 compatibles instead of sdm845 compatibles > > - Remove "notused" interconnect (which apparently was blindly copied from > > my old patches) > > - Use dispcc node example from dt-bindings, removing clocks which aren't > > documented or used by the driver and fixing the region size. > > > > Fixes: 7c1dffd471b1 ("arm64: dts: qcom: sm8250.dtsi: add display system nodes") > > Signed-off-by: Jonathan Marek > > --- > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 31 +++++++--------------------- > > 1 file changed, 8 insertions(+), 23 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > > index 947e1accae3a..693ac533f9b6 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > > @@ -2323,14 +2323,13 @@ usb_2_dwc3: dwc3@a800000 { > > }; > > > > mdss: mdss@ae00000 { > > - compatible = "qcom,sdm845-mdss"; > > + compatible = "qcom,sm8250-mdss"; > > reg = <0 0x0ae00000 0 0x1000>; > > reg-names = "mdss"; > > > > - interconnects = <&gem_noc MASTER_AMPSS_M0 &config_noc SLAVE_DISPLAY_CFG>, > > - <&mmss_noc MASTER_MDP_PORT0 &mc_virt SLAVE_EBI_CH0>, > > + interconnects = <&mmss_noc MASTER_MDP_PORT0 &mc_virt SLAVE_EBI_CH0>, > > <&mmss_noc MASTER_MDP_PORT1 &mc_virt SLAVE_EBI_CH0>; > > - interconnect-names = "notused", "mdp0-mem", "mdp1-mem"; > > + interconnect-names = "mdp0-mem", "mdp1-mem"; > > > > power-domains = <&dispcc MDSS_GDSC>; > > > > @@ -2356,7 +2355,7 @@ mdss: mdss@ae00000 { > > ranges; > > > > mdss_mdp: mdp@ae01000 { > > - compatible = "qcom,sdm845-dpu"; > > + compatible = "qcom,sm8250-dpu"; > > reg = <0 0x0ae01000 0 0x8f000>, > > <0 0x0aeb0000 0 0x2008>; > > reg-names = "mdp", "vbif"; > > @@ -2580,7 +2579,7 @@ opp-358000000 { > > > > dispcc: clock-controller@af00000 { > > compatible = "qcom,sm8250-dispcc"; > > - reg = <0 0x0af00000 0 0x20000>; > > + reg = <0 0x0af00000 0 0x10000>; > > mmcx-supply = <&mmcx_reg>; > > clocks = <&rpmhcc RPMH_CXO_CLK>, > > <&dsi0_phy 0>, > > @@ -2588,28 +2587,14 @@ dispcc: clock-controller@af00000 { > > <&dsi1_phy 0>, > > <&dsi1_phy 1>, > > <0>, > > - <0>, > > - <0>, > > - <0>, > > - <0>, > > - <0>, > > - <0>, > > - <0>, > > - <&sleep_clk>; > > + <0>; > > clock-names = "bi_tcxo", > > "dsi0_phy_pll_out_byteclk", > > "dsi0_phy_pll_out_dsiclk", > > "dsi1_phy_pll_out_byteclk", > > "dsi1_phy_pll_out_dsiclk", > > - "dp_link_clk_divsel_ten", > > - "dp_vco_divided_clk_src_mux", > > - "dptx1_phy_pll_link_clk", > > - "dptx1_phy_pll_vco_div_clk", > > - "dptx2_phy_pll_link_clk", > > - "dptx2_phy_pll_vco_div_clk", > > - "edp_phy_pll_link_clk", > > - "edp_phy_pll_vco_div_clk", > > - "sleep_clk"; > > + "dp_phy_pll_link_clk", > > + "dp_phy_pll_vco_div_clk"; > > #clock-cells = <1>; > > #reset-cells = <1>; > > #power-domain-cells = <1>; > > -- > > 2.26.1 > > > > > -- > With best wishes > Dmitry