From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93503C433DB for ; Tue, 16 Mar 2021 23:27:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65F2A64F96 for ; Tue, 16 Mar 2021 23:27:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229632AbhCPX0o (ORCPT ); Tue, 16 Mar 2021 19:26:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbhCPX0T (ORCPT ); Tue, 16 Mar 2021 19:26:19 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB25CC061762 for ; Tue, 16 Mar 2021 16:26:19 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id mz6-20020a17090b3786b02900c16cb41d63so314969pjb.2 for ; Tue, 16 Mar 2021 16:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=w5QajIxS6y5Fi0iTPRAGrD8S6mOwAPT15FoB2waGPFM=; b=FzPs1avgRjsFZ3d35srKz+eBOPtuhZPWPiqY8vX4CiI+UonDB4LwUENMF1EWSIYIOS 57SgIkt4SgO4qJ5h+GZBUaY/AWZld2KW49mvMOi5iTScTH9ojaR4ieyLJIgbJLatef46 zCepIuqzZRDAbX/HbgGNRErpChZRZ8jjiDmC0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=w5QajIxS6y5Fi0iTPRAGrD8S6mOwAPT15FoB2waGPFM=; b=fiwZyhqQbwKqmJBEhT9azu/BTh3YVGqE+L7jjtatFxGejDuBAg8S3ESQRAsLQ4D9pn s6y7GwGM0s7jfcA1BY50DGDBESgJAgya9r1clx1gmtXc6zmAvd/ag4V3NF1MIif2VKPf HEHm3BNQyzbpZ9RbmzaO3dKOIaUQnc+TnOCageeBQq8qI9E8Y3sT/VZpiZuZ7h1Fx3hP ouFw3iqp9n5A3t56SNhjeEAe0yFU/dVfbpmQ67/zqVNdnY32+1BoO/+svTkuOgiF5GN9 vqynZ/wH56T7KvsBGLO7MIWMbxDomH8SrSbI8WvIrKw7KiClKR/dTtLnF3sWOyQckyzs 3Nqw== X-Gm-Message-State: AOAM530df66d4xjIBg3yKFXDuS6zR7M6p9l6nvO6z1muvHgvIE0PNrwB D9bGtBNTWVQQ17D1x6CQAvLEgf/Ig1aGUw== X-Google-Smtp-Source: ABdhPJzA1Ew/ucDvRg38/OJGbarhjjqP83rSwho6aOC3HYRd5w679AuzfHyi8xZpQhflL2/8N0zgFA== X-Received: by 2002:a17:90a:b63:: with SMTP id 90mr1424994pjq.124.1615937179059; Tue, 16 Mar 2021 16:26:19 -0700 (PDT) Received: from localhost ([2620:15c:202:1:b471:7d:bf21:d7dd]) by smtp.gmail.com with UTF8SMTPSA id v7sm17515668pfv.93.2021.03.16.16.26.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Mar 2021 16:26:18 -0700 (PDT) Date: Tue, 16 Mar 2021 16:26:16 -0700 From: Matthias Kaehlcke To: satya priya Cc: Andy Gross , Bjorn Andersson , Liam Girdwood , Mark Brown , Rob Herring , rnayak@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kgunda@codeaurora.org, David Collins Subject: Re: [PATCH V2 3/5] arm64: dts: qcom: sc7280: Add RPMh regulators for sc7280-idp Message-ID: References: <1615816454-1733-1-git-send-email-skakit@codeaurora.org> <1615816454-1733-4-git-send-email-skakit@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1615816454-1733-4-git-send-email-skakit@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Mar 15, 2021 at 07:24:12PM +0530, satya priya wrote: > Add regulator devices for SC7280 as RPMh regulators. This ensures > that consumers are able to modify the physical state of PMIC > regulators. > > Signed-off-by: satya priya > --- > Changes in V2: > - Corrected the indentation for "compatible" and "qcom,pmic-id" under > pm8350c-regulators as per Konrad's comment. > > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 212 ++++++++++++++++++++++++++++++++ > 1 file changed, 212 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > index 428f863..78effe5 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > @@ -22,6 +22,218 @@ > }; > }; > > +&apps_rsc { > + pm7325-regulators { > + compatible = "qcom,pm7325-rpmh-regulators"; > + qcom,pmic-id = "b"; > + > + vreg_s1b_1p8: smps1 { > + regulator-min-microvolt = <1856000>; For most LDOs their 'Active minimum voltage' is specified as their minimum, however for S1B and S8B it's the 'Nominal voltage. Is that intentional? There might be a misunderstanding on my side what the values in the datasheet actually mean, see my comment at the end. > + regulator-max-microvolt = <2040000>; > + }; > + > + vreg_s7b_0p9: smps7 { > + regulator-min-microvolt = <535000>; According to the datasheet the minimum voltage of the S7B regulator is 904 mV. > + regulator-max-microvolt = <1120000>; > + }; > + > + vreg_s8b_1p2: smps8 { > + regulator-min-microvolt = <1256000>; > + regulator-max-microvolt = <1500000>; > + }; > + > + vreg_l1b_0p8: ldo1 { > + regulator-min-microvolt = <825000>; > + regulator-max-microvolt = <925000>; > + }; > + > + vreg_l2b_3p0: ldo2 { > + regulator-min-microvolt = <2700000>; > + regulator-max-microvolt = <3544000>; > + }; Another question that came up for sc7180-trogdor regulators, whose core regulator config was derived from sc7180-idp: the label suggests that this regulator is supposed to supply 3V, however the range spans from 2.7 to 3.54V. Shouldn't it be narrower around 3V? Same for other some regulators. > + > + vreg_l6b_1p2: ldo6 { > + regulator-min-microvolt = <1140000>; The datasheet says the minimum for L6B is 1.2V. > + regulator-max-microvolt = <1260000>; > + }; > + > + vreg_l7b_2p9: ldo7 { > + regulator-min-microvolt = <2960000>; > + regulator-max-microvolt = <2960000>; > + }; This regulator has a fixed voltage in difference to the others, why is that? > + > + vreg_l8b_0p9: ldo8 { > + regulator-min-microvolt = <870000>; > + regulator-max-microvolt = <970000>; > + }; > + > + vreg_l9b_1p2: ldo9 { > + regulator-min-microvolt = <1080000>; > + regulator-max-microvolt = <1304000>; > + }; > + > + vreg_l11b_1p7: ldo11 { > + regulator-min-microvolt = <1504000>; The datasheet says the mininum voltage for L11B is 1.776V. > + regulator-max-microvolt = <2000000>; > + }; > + > + vreg_l12b_0p8: ldo12 { > + regulator-min-microvolt = <751000>; > + regulator-max-microvolt = <824000>; > + }; > + > + vreg_l13b_0p8: ldo13 { > + regulator-min-microvolt = <530000>; > + regulator-max-microvolt = <824000>; The max for L13B is 880mV, is this a copy and paste from L12B? > + }; > + > + vreg_l14b_1p2: ldo14 { > + regulator-min-microvolt = <1080000>; The datasheet says the mininum voltage for L14B is 1.2V. > + regulator-max-microvolt = <1304000>; > + }; > + > + vreg_l15b_0p8: ldo15 { > + regulator-min-microvolt = <765000>; > + regulator-max-microvolt = <1020000>; > + }; > + > + vreg_l16b_1p2: ldo16 { > + regulator-min-microvolt = <1100000>; The datasheet says the mininum voltage for L16B is 1.2V. > + regulator-max-microvolt = <1300000>; > + }; > + > + vreg_l17b_1p8: ldo17 { > + regulator-min-microvolt = <1700000>; The datasheet says the mininum voltage for L17B is 1.8V. > + regulator-max-microvolt = <1900000>; > + }; > + > + vreg_l18b_1p8: ldo18 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2000000>; > + }; > + > + vreg_l19b_1p8: ldo19 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; Is a fixed voltage intentional here? > + }; > + }; > + > + pm8350c-regulators { > + compatible = "qcom,pm8350c-rpmh-regulators"; I can't find the datasheet for this chip, skipping this part. > + pmr735a-regulators { > + compatible = "qcom,pmr735a-rpmh-regulators"; > + qcom,pmic-id = "e"; > + > + vreg_l2e_1p2: ldo2 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + }; > + > + vreg_l3e_0p9: ldo3 { > + regulator-min-microvolt = <912000>; > + regulator-max-microvolt = <1020000>; According to the datasheet min and max for L3E is 1.2V. The datasheet lists different voltages for 'SM8350 lineup' and 'SM8xyz' lineup though, does that mean that the voltages aren't limitations of what the regulators can provide but what their consumers support? There are also deltas for the remaining regulators, but now I'm in doubt about what the info in the datasheet actually means. > + }; > + > + vreg_l4e_1p7: ldo4 { > + regulator-min-microvolt = <1776000>; > + regulator-max-microvolt = <1890000>; > + }; > + > + vreg_l5e_0p8: ldo5 { > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <800000>; > + }; > + > + vreg_l6e_0p8: ldo6 { > + regulator-min-microvolt = <480000>; > + regulator-max-microvolt = <904000>; > + }; > + }; > +}; > + > &qupv3_id_0 { > status = "okay"; > };