From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A9EC433E0 for ; Wed, 24 Mar 2021 00:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C05BF619EC for ; Wed, 24 Mar 2021 00:50:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233916AbhCXAth (ORCPT ); Tue, 23 Mar 2021 20:49:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233784AbhCXAtS (ORCPT ); Tue, 23 Mar 2021 20:49:18 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02138C0613D8 for ; Tue, 23 Mar 2021 17:49:17 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id t18so10830587pjs.3 for ; Tue, 23 Mar 2021 17:49:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pqlDAkfpFxPvtCYcs4rpRWhh2vQJErVgPPsfWn8QpKE=; b=NMbztM4I619xLFkutZ9T3xKcbWtEQumZDAH4+TzP5UeHAXdbRCmG+ik1Gwrl+skzEh 4kheY1dwKvniJdmn3cmFutU2xCahjejs7pRg9M7leVP9nzua4+RoMi0oPOJ7RXVbqMj8 pyJvHHqmSYOliRyhTW08AmBGcFiXMc/L7X3Jc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pqlDAkfpFxPvtCYcs4rpRWhh2vQJErVgPPsfWn8QpKE=; b=ugk52X75RVx1iSfnsACOQWjaArzqNnvimAKysoxbig1bIhoPY6l7aT/9ewHCvlUXNL 4BOtVtzDG6jVCvffqVUp7PkPxbm+EL01+fmQCiITU9/Yic50dnD0KW+exR6lgdV06i8u WgRNnzc0K611CMgYhRKTwZf1+j1Tc5/jlMXdGMwFN3W79GovtNVN/F4HZw8Aj7llzV04 HozFDofNC6RQXjooEpwwTtUNwIH/P5McdovtfcXRJCDSp7WYT5RWNOtZqmBOm5zBD/VA NFw1EGWJy7kIl+q/wzhSLy8j6Brdwv4tPAMpXiKie4yUx6kON2wIvm8SAfTsVRNzcmXx O2jw== X-Gm-Message-State: AOAM531dWKjngfH2eEqtABBOhopN5bYT05ZSaxPu7/5533UY9RP/pYTP dlT/ZUP44ca0RW9b609wqQJjpQ== X-Google-Smtp-Source: ABdhPJyvh4woIN16EDJ0HLxyAHCrRhNd5iy6Y6QmH6u4YlHQwt/o8oJwXx9AGorbf/T0wQ9vH02vaw== X-Received: by 2002:a17:903:30c3:b029:e6:5008:f7a7 with SMTP id s3-20020a17090330c3b02900e65008f7a7mr1017020plc.73.1616546957382; Tue, 23 Mar 2021 17:49:17 -0700 (PDT) Received: from localhost ([2620:15c:202:1:40a3:9725:46c3:85f6]) by smtp.gmail.com with UTF8SMTPSA id w203sm344685pff.59.2021.03.23.17.49.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Mar 2021 17:49:16 -0700 (PDT) Date: Tue, 23 Mar 2021 17:49:14 -0700 From: Matthias Kaehlcke To: Greg Kroah-Hartman Cc: Sandeep Maheswaram , Andy Gross , Bjorn Andersson , Rob Herring , Felipe Balbi , Stephen Boyd , Doug Anderson , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manu Gautam Subject: Re: [PATCH v5 3/4] usb: dwc3: qcom: Configure wakeup interrupts and set genpd active wakeup flag Message-ID: References: <1616434280-32635-1-git-send-email-sanm@codeaurora.org> <1616434280-32635-4-git-send-email-sanm@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 23, 2021 at 01:11:18PM +0100, Greg Kroah-Hartman wrote: > On Mon, Mar 22, 2021 at 11:01:19PM +0530, Sandeep Maheswaram wrote: > > Configure interrupts based on hs_phy_mode to avoid triggering of > > interrupts during system suspend and suspends successfully. > > Set genpd active wakeup flag for usb gdsc if wakeup capable devices > > are connected so that wake up happens without reenumeration. > > Add helper functions to enable,disable wake irqs. > > That feels like a lot of different things all in one patch. Sandeep: one thing you could do to reduce the churn is to add dwc3_qcom_enable/disable_wakeup_irq() in a separate patch, without any functional changes. Then this patch would only add the different branches based on the PHY mode. The handling of the power domain could probably also be done in a separate patch, if I recall correctly it is only an optimization.