From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C716C433E0 for ; Wed, 24 Mar 2021 09:14:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFC3F619B4 for ; Wed, 24 Mar 2021 09:14:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231601AbhCXJOH (ORCPT ); Wed, 24 Mar 2021 05:14:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:53636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234605AbhCXJNr (ORCPT ); Wed, 24 Mar 2021 05:13:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 90ED06157F; Wed, 24 Mar 2021 09:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616577227; bh=w8CRVnJFyS/XR+Mj1hn0bNzvz+r35MHD7pK0TCVHjD4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uo2mt6FtAPAq/f6vQn46VxbR2DRGY30BApaODqpGYP2p0eskhkEKbE+6NUzIy9+Mb CqoaAFK4QSC2+gVl5gUS41iuTAxCz4f/4hCOL3gPdEU914dfbdCc5YO8YKCgDN2ksx Gkt/9S6Pw4Y4qwl3JIo32a9eSTw35cKyzKc51DfI= Date: Wed, 24 Mar 2021 10:13:44 +0100 From: Greg Kroah-Hartman To: Michal Simek Cc: Sai Krishna Potthuri , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, git@xilinx.com, saikrishna12468@gmail.com Subject: Re: [PATCH v4 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Message-ID: References: <1615969516-87663-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> <1615969516-87663-4-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Mar 24, 2021 at 10:02:53AM +0100, Michal Simek wrote: > > > On 3/24/21 9:49 AM, Greg Kroah-Hartman wrote: > > On Wed, Mar 24, 2021 at 09:29:12AM +0100, Michal Simek wrote: > >> On 3/23/21 2:42 PM, Greg Kroah-Hartman wrote: > >>> On Wed, Mar 17, 2021 at 01:55:16PM +0530, Sai Krishna Potthuri wrote: > >>>> Adding pinctrl driver for Xilinx ZynqMP platform. > >>>> This driver queries pin information from firmware and registers > >>>> pin control accordingly. > >>>> > >>>> Signed-off-by: Sai Krishna Potthuri > >>>> --- > >>>> drivers/pinctrl/Kconfig | 13 + > >>>> drivers/pinctrl/Makefile | 1 + > >>>> drivers/pinctrl/pinctrl-zynqmp.c | 1030 ++++++++++++++++++++++++++++++ > >>>> 3 files changed, 1044 insertions(+) > >>>> create mode 100644 drivers/pinctrl/pinctrl-zynqmp.c > >>>> > >>>> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > >>>> index 815095326e2d..25d3c7208975 100644 > >>>> --- a/drivers/pinctrl/Kconfig > >>>> +++ b/drivers/pinctrl/Kconfig > >>>> @@ -341,6 +341,19 @@ config PINCTRL_ZYNQ > >>>> help > >>>> This selects the pinctrl driver for Xilinx Zynq. > >>>> > >>>> +config PINCTRL_ZYNQMP > >>>> + bool "Pinctrl driver for Xilinx ZynqMP" > >>> > >>> Please make this work as a module. > >> > >> The most of pinctrl drivers are builtin modules now which is not excuse > >> it is just fact. > >> $ git grep module_pla drivers/pinctrl/ | wc -l > >> 40 > >> $ git grep builtin_pla drivers/pinctrl/ | wc -l > >> 64 > > > > For new ones, we can do better, don't make us have to go back and fix > > this up later. > > As I said not a big deal. If this is the way to go then I these rules > should be followed which is not what it is happening based on 3 latest > pinctrl drivers below. I do not disagree, but I point out issues when I see them, you got unlucky :)