From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6133C433ED for ; Thu, 8 Apr 2021 23:01:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8835361106 for ; Thu, 8 Apr 2021 23:01:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232882AbhDHXBw (ORCPT ); Thu, 8 Apr 2021 19:01:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232426AbhDHXBt (ORCPT ); Thu, 8 Apr 2021 19:01:49 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 313C6C061762 for ; Thu, 8 Apr 2021 16:01:38 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so4016326pjh.1 for ; Thu, 08 Apr 2021 16:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bMrE4GiUoOivb2bToZQgjp/sVzfX0cAOSgbBK8yv3Rw=; b=cii3FE4MB8S8UrXrkif8XXeLL1Mwzb08ZPDQd51qU2KVaRmBoyPGM0ofeaQm3g4YI/ WXjb7fnwr0EoUzeIa65Jym8Dn3ZuOU3ocqQOVi51W76xCFaBwJVQoJQ921adRrHFV782 1/pJDHZF7Fq5g8reyvsZcnXhuXqD5KBwo24ug= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bMrE4GiUoOivb2bToZQgjp/sVzfX0cAOSgbBK8yv3Rw=; b=crMzDzIXM1DdbhGRCK+GTahh4GYHU1zyKFryhiuSv3JOPMXPafs226JKlUy0t/Qbua j+POI/+7kIAP9Q9joizb49i/Fj3u+pl2Dgu+RxGOcbA/efjJSWK3G/Vl2EcbRziOucUy KYkef4tLeaalbaUaa4jQuBS+sA5BgWyFtf79rLizIu5VpBLPxCLDz+mLl5QHE73eQmPl CFqWgx4oxNvCoV3HhE8v+lY9PFa/FL2k/Uvox1Ys2BqJS1ITvLyC2r/KsyU1edXuHU1A cFyxtwsHoiXyHyp3bLzl0870Mw2E60r5t5upNQhU7oBh6KqSUGunTV9bZDQTpKyr+tg5 Dhvg== X-Gm-Message-State: AOAM5332qbP/CJt9HrXn7bZuf+A7qcUSZHUFzjZyt2Ou3S9ZYRqyTTWN dRzyhvIvc7a7xIeis56yswdPSQ== X-Google-Smtp-Source: ABdhPJyEsPr4uBS5yJ3CtibMEZDiJEdrrDZQ2RqP03A+XSaeEUdrXB0sUbmtgzamZphqtZWujV4KcA== X-Received: by 2002:a17:902:da8d:b029:e5:c7d9:81f2 with SMTP id j13-20020a170902da8db02900e5c7d981f2mr9818988plx.21.1617922897699; Thu, 08 Apr 2021 16:01:37 -0700 (PDT) Received: from localhost ([2620:15c:202:201:d013:d350:4066:89b8]) by smtp.gmail.com with UTF8SMTPSA id j16sm409909pfa.213.2021.04.08.16.01.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Apr 2021 16:01:37 -0700 (PDT) Date: Thu, 8 Apr 2021 16:01:36 -0700 From: Matthias Kaehlcke To: Rob Herring Cc: Greg Kroah-Hartman , Alan Stern , Frank Rowand , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Douglas Anderson , Peter Chen , Michal Simek , linux-usb@vger.kernel.org, Ravi Chandra Sadineni , Bastien Nocera , devicetree@vger.kernel.org, Stephen Boyd Subject: Re: [PATCH v6 3/5] of/platform: Add stubs for of_platform_device_create/destroy() Message-ID: References: <20210405201817.3977893-1-mka@chromium.org> <20210405124900.v6.3.I08fd2e1c775af04f663730e9fb4d00e6bbb38541@changeid> <20210408152112.GA1493009@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210408152112.GA1493009@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Apr 08, 2021 at 10:21:12AM -0500, Rob Herring wrote: > On Mon, Apr 05, 2021 at 01:18:15PM -0700, Matthias Kaehlcke wrote: > > Code for platform_device_create() and of_platform_device_create() is > > platform_device_create()? ack, should be of_platform_device_destroy() > > only generated if CONFIG_OF_ADDRESS=y. Add stubs to avoid unresolved > > symbols when CONFIG_OF_ADDRESS is not set. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > > > Changes in v7: > > - none > > > > Changes in v6: > > - patch added to the series > > > > include/linux/of_platform.h | 22 ++++++++++++++++++---- > > 1 file changed, 18 insertions(+), 4 deletions(-) > > > > diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h > > index 84a966623e78..d15b6cd5e1c3 100644 > > --- a/include/linux/of_platform.h > > +++ b/include/linux/of_platform.h > > @@ -61,16 +61,18 @@ static inline struct platform_device *of_find_device_by_node(struct device_node > > } > > #endif > > > > +extern int of_platform_bus_probe(struct device_node *root, > > + const struct of_device_id *matches, > > + struct device *parent); > > This is also only built for CONFIG_OF_ADDRESS. But there's no need for > an empty function as it is powerpc only and should never have a new > user. ok