From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF87C433DB for ; Tue, 30 Mar 2021 08:41:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCE936198A for ; Tue, 30 Mar 2021 08:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231313AbhC3IlM (ORCPT ); Tue, 30 Mar 2021 04:41:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:43184 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231511AbhC3Ikk (ORCPT ); Tue, 30 Mar 2021 04:40:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 44B886198F; Tue, 30 Mar 2021 08:40:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617093640; bh=5vjWHQpNnWwzD+C6Uz33hAqzurkp949O30Cxa1ACg+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o4xqREtMQ8bpOCp6JwQ/3PzO7VMBuDSe7ZnSjC6GYVtJ6HrzoEKwDVAgVYngc550c yCkq/FDploTzNru+QMIPcLrXIN5xQexxLy/aQW+bas9TDRAkth582KEpNHu4TQ7jxd m/Ja/WBc8YHofa5W1SCk8BYlUgp6ltyaR5f2+d19vgifk7Hztcxi89s+WDEI9/2ajJ nUrRHJqp2WwRIKKgI+VjaMk+8124TloR2JctPrPHh4ZW/KcZUCN34147qu0Ya6uYWJ fLevnAqIpW0TNYczFYW2MOaJE+desJ0bnflqoCtsJNnpN7UDmgKHXKgk6oODRSNYZL td6WS0Mj+hJzA== Date: Tue, 30 Mar 2021 14:10:35 +0530 From: Vinod Koul To: Srinivas Kandagatla Cc: yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, robh@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 5/9] soundwire: qcom: update register read/write routine Message-ID: References: <20210326063944.31683-1-srinivas.kandagatla@linaro.org> <20210326063944.31683-6-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210326063944.31683-6-srinivas.kandagatla@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26-03-21, 06:39, Srinivas Kandagatla wrote: > + swrm->reg_write(swrm, SWRM_CMD_FIFO_WR_CMD, val); > + > + /* version 1.3 or less */ > + if (swrm->version <= 0x01030000) > + usleep_range(150, 155); > + > + if (cmd_id == SWR_BROADCAST_CMD_ID) { > + /* > + * sleep for 10ms for MSM soundwire variant to allow broadcast > + * command to complete. > + */ > + ret = wait_for_completion_timeout(&swrm->broadcast, > + msecs_to_jiffies(TIMEOUT_MS)); > + if (!ret) > + ret = SDW_CMD_IGNORED; > + else > + ret = SDW_CMD_OK; > > - if (!ret) { > - ret = SDW_CMD_IGNORED; > - goto err; > } else { > ret = SDW_CMD_OK; > } Maybe add a comment here that we dont get status so write is assumed to be OK -- ~Vinod