From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F17C433C1 for ; Tue, 30 Mar 2021 08:43:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C4D26157F for ; Tue, 30 Mar 2021 08:43:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231576AbhC3InW (ORCPT ); Tue, 30 Mar 2021 04:43:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:43962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231655AbhC3InJ (ORCPT ); Tue, 30 Mar 2021 04:43:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 291ED61919; Tue, 30 Mar 2021 08:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617093789; bh=BzVGzxF47npQxoaPhUx9SUpW2ax62qrGKvP/1FIKvQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VE57U+us+WY2P7L75NyhztMPzKv47qlr7zFsI5g4VEu/PGQgC7xXcGldZ5myuSx97 FAFZuCT6YDQC14wM6lTEZ0NZqCkv6qqnY0SiBku0HR2MYI03pj7x2gn5UZDxkiQ9hl PRVayX9J4rxOfKc/3mksaBV8qzQVXmVY2nBu42qNs84OlFOYbJQWz5/mdysb95q1xQ reLoX0cMiTVDPaoo/N/ZU5uqILVqaAdQSYwpceTNJXvv49SqtXxpnPwMNI9dsAQMkm hHymudupflnovj1MSU7neN1lI/RcUocquJ/0RkEvWwuniyvf0n+UX0qnIVwcP+P9Ft NF8Fj6wAsEURw== Date: Tue, 30 Mar 2021 14:13:04 +0530 From: Vinod Koul To: Srinivas Kandagatla Cc: yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, robh@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 6/9] soundwire: qcom: add support to new interrupts Message-ID: References: <20210326063944.31683-1-srinivas.kandagatla@linaro.org> <20210326063944.31683-7-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210326063944.31683-7-srinivas.kandagatla@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26-03-21, 06:39, Srinivas Kandagatla wrote: > - ctrl->reg_write(ctrl, SWRM_INTERRUPT_CLEAR, sts); > + do { > + for (i = 0; i < SWRM_INTERRUPT_MAX; i++) { > + value = intr_sts_masked & (1 << i); BIT(i) istead of shifiting? > + if (!value) > + continue; > + > + switch (value) { > + case SWRM_INTERRUPT_STATUS_SLAVE_PEND_IRQ: > + devnum = qcom_swrm_get_alert_slave_dev_num(swrm); > + if (devnum < 0) { > + dev_err_ratelimited(swrm->dev, > + "no slave alert found.spurious interrupt\n"); > + } else { > + sdw_handle_slave_status(&swrm->bus, swrm->status); > + } > > - if (sts & SWRM_INTERRUPT_STATUS_SPECIAL_CMD_ID_FINISHED) > - complete(&ctrl->broadcast); > + break; > + case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED: > + case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS: > + dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n", > + __func__); This should be debug -- ~Vinod