From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2657BC433B4 for ; Tue, 20 Apr 2021 18:02:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4083613D2 for ; Tue, 20 Apr 2021 18:02:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233583AbhDTSCs (ORCPT ); Tue, 20 Apr 2021 14:02:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233587AbhDTSCp (ORCPT ); Tue, 20 Apr 2021 14:02:45 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C62B5C06174A for ; Tue, 20 Apr 2021 11:02:13 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id nm3-20020a17090b19c3b029014e1bbf6c60so16672793pjb.4 for ; Tue, 20 Apr 2021 11:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hbT6P4sTnHjPVBNP+gpODkwhWALRT12GXZ+BrAU9z6c=; b=IK3Klm6cN5YqBN7qVuJ4lLmzTgfg3eCcqpFIHbGZOJH1ExUBQp0z3TU+fzS11X9elp nMS/d5adt4C5erUZjmqL3j0sGxixcUKBKBU/XVjwwhNYpvycOGFJUZunmlzn5qykoY3E t6lZw6dvzFt5qu67rp+6m0PPfV6Phco9cMnWg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hbT6P4sTnHjPVBNP+gpODkwhWALRT12GXZ+BrAU9z6c=; b=f8NmN8dyZZZ9sYGNQmccMZwoMO1SuCbnMV0ssICZmLnoCQil5D0PNWAVN5fRyu45Q3 7yuP45VDDvuzO2VgtDAuXvjuSJxP2x0P84UyStl9JUxvk2JPohlj/VYKR0hbtdCN+d/Z R+DtuAgD3ifeRuoGLT5Unca3yZ5VrGHwDTfdr6oeBdW/KERe3uXXxArpFj6qmQsMZGSK ZKWA/2Czc2TYFqxRfknQyFGG0EDlZjgv7YXdu6smXheSLNlaxEzVWCNKHc4uwag9UCFG yh1houY+vmxeJUE1ryeBr5afVDP3GeKgtlrzbzsj4l/qnjVeK3C1E/BL+wBbtVGmSU+/ w+pQ== X-Gm-Message-State: AOAM53205hktumG000MM8rtFZZUhszFmq0BgzW2MkEhQ+8FKOVpGAb19 BFTdE15ncpUQOarXY+YMzvD2WA== X-Google-Smtp-Source: ABdhPJx1smAbs/nJboZ6ngogE39uC6bgXMI37IgfFLX/P1zHxGxFgpyakNxvN7zFAybgcJgGWkDOiQ== X-Received: by 2002:a17:90a:302:: with SMTP id 2mr6540846pje.34.1618941732683; Tue, 20 Apr 2021 11:02:12 -0700 (PDT) Received: from localhost ([2620:15c:202:201:7a9:7e56:e9c3:13e8]) by smtp.gmail.com with UTF8SMTPSA id f10sm3103078pju.27.2021.04.20.11.02.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Apr 2021 11:02:12 -0700 (PDT) Date: Tue, 20 Apr 2021 11:02:11 -0700 From: Matthias Kaehlcke To: satya priya Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kgunda@codeaurora.org Subject: Re: [RESEND PATCH V3 5/5] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280 Message-ID: References: <1618398783-7834-1-git-send-email-skakit@codeaurora.org> <1618398783-7834-6-git-send-email-skakit@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1618398783-7834-6-git-send-email-skakit@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Apr 14, 2021 at 04:43:03PM +0530, satya priya wrote: > Subject: arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280 Please make sure to distinguish between the SoC (sc7280) and the board (sc7280-idp), this patch primarily adds stuff to the board not the SoC, this should be clear from the subject. > Include pm7325, pm8350c, pmk8350 and pmr735a DT files. How about something like 'The sc7280-idp has four PMICs, include their .dtsi files'? > Add channel nodes for pmk8350_vadc. It's not super important, but I don't like it when things like this get sneaked in with a commit message saying 'Include PMIC DT files for sc7280'. I would suggest a separate patch. And please mention that the channels are for the on die temperatures of the PMICs. > Also, add the thermal_zones node in dtsi. This is not the right patch to add it. This patch is about the sc7280-board and doesn't do anything (directly) with thermal zones. However other patches further down in the stack of in this series require the 'thermal-zones' to exist, hence the node should exist before these patches reference it. A dedicated patch adding the node seems like the best option to me.