From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D891CC433B4 for ; Tue, 13 Apr 2021 15:03:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A75B0613B7 for ; Tue, 13 Apr 2021 15:03:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345520AbhDMPD0 (ORCPT ); Tue, 13 Apr 2021 11:03:26 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48516 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242462AbhDMPDZ (ORCPT ); Tue, 13 Apr 2021 11:03:25 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lWKZA-00GUMK-8h; Tue, 13 Apr 2021 17:03:00 +0200 Date: Tue, 13 Apr 2021 17:03:00 +0200 From: Andrew Lunn To: Michal =?utf-8?B?Vm9rw6HEjQ==?= Cc: Rob Herring , Shawn Guo , Fabio Estevam , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ARM: dts: imx6dl-yapp4: Fix RGMII connection to QCA8334 switch Message-ID: References: <1618325157-5774-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1618325157-5774-1-git-send-email-michal.vokac@ysoft.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Apr 13, 2021 at 04:45:57PM +0200, Michal Vokáč wrote: > The FEC does not have a PHY so it should not have a phy-handle. It is > connected to the switch at RGMII level so we need a fixed-link sub-node > on both ends. > > This was not a problem until the qca8k.c driver was converted to PHYLINK > by commit b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of > PHYLIB"). That commit revealed the FEC configuration was not correct. > > Fixes: 87489ec3a77f ("ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards") > Cc: stable@vger.kernel.org > Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Andrew