From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Jacopo Mondi <jacopo@jmondi.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: media: renesas,vin: Make resets optional on R-Car Gen1
Date: Sat, 1 May 2021 12:21:42 +0200 [thread overview]
Message-ID: <YI0rtsG7nbRsrI6d@oden.dyn.berto.se> (raw)
In-Reply-To: <217c8197efaee7d803b22d433abb0ea8e33b84c6.1619700314.git.geert+renesas@glider.be>
Hi Geert,
On 2021-04-29 14:45:52 +0200, Geert Uytterhoeven wrote:
> The "resets" property is not present on R-Car Gen1 SoCs.
> Supporting it would require migrating from renesas,cpg-clocks to
> renesas,cpg-mssr.
>
> Fixes: 905fc6b1bfb4a631 ("dt-bindings: rcar-vin: Convert bindings to json-schema")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Note that VIN is not yet enabled in r8a777[89].dtsi.
> ---
> .../bindings/media/renesas,vin.yaml | 46 ++++++++++++-------
> 1 file changed, 29 insertions(+), 17 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,vin.yaml b/Documentation/devicetree/bindings/media/renesas,vin.yaml
> index 79c936b313ea91ae..19fccc2fd8ece120 100644
> --- a/Documentation/devicetree/bindings/media/renesas,vin.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,vin.yaml
> @@ -194,23 +194,35 @@ required:
> - interrupts
> - clocks
> - power-domains
> - - resets
> -
> -if:
> - properties:
> - compatible:
> - contains:
> - enum:
> - - renesas,vin-r8a7778
> - - renesas,vin-r8a7779
> - - renesas,rcar-gen2-vin
> -then:
> - required:
> - - port
> -else:
> - required:
> - - renesas,id
> - - ports
> +
> +allOf:
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,vin-r8a7778
> + - renesas,vin-r8a7779
> + then:
> + required:
> + - resets
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,vin-r8a7778
> + - renesas,vin-r8a7779
> + - renesas,rcar-gen2-vin
> + then:
> + required:
> + - port
> + else:
> + required:
> + - renesas,id
> + - ports
>
> additionalProperties: false
>
> --
> 2.25.1
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2021-05-01 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 12:45 [PATCH] dt-bindings: media: renesas,vin: Make resets optional on R-Car Gen1 Geert Uytterhoeven
2021-05-01 10:21 ` Niklas Söderlund [this message]
2021-05-03 20:02 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YI0rtsG7nbRsrI6d@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jacopo@jmondi.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).