From: Andrew Lunn <andrew@lunn.ch>
To: Prasanna Vengateshan <prasanna.vengateshan@microchip.com>
Cc: netdev@vger.kernel.org, olteanv@gmail.com, robh+dt@kernel.org,
UNGLinuxDriver@microchip.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org, vivien.didelot@gmail.com,
f.fainelli@gmail.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 net-next 2/9] net: phy: Add support for LAN937x T1 phy driver
Date: Thu, 22 Apr 2021 14:45:41 +0200 [thread overview]
Message-ID: <YIFv9Wcp94395Hbb@lunn.ch> (raw)
In-Reply-To: <20210422094257.1641396-3-prasanna.vengateshan@microchip.com>
> +#define PORT_T1_PHY_RESET BIT(15)
> +#define PORT_T1_PHY_LOOPBACK BIT(14)
> +#define PORT_T1_SPEED_100MBIT BIT(13)
> +#define PORT_T1_POWER_DOWN BIT(11)
> +#define PORT_T1_ISOLATE BIT(10)
> +#define PORT_T1_FULL_DUPLEX BIT(8)
These appear to be standard BMCR_ values. Please don't define your
own.
> +
> +#define REG_PORT_T1_PHY_BASIC_STATUS 0x01
> +
> +#define PORT_T1_MII_SUPPRESS_CAPABLE BIT(6)
> +#define PORT_T1_LINK_STATUS BIT(2)
> +#define PORT_T1_EXTENDED_CAPABILITY BIT(0)
> +
> +#define REG_PORT_T1_PHY_ID_HI 0x02
> +#define REG_PORT_T1_PHY_ID_LO 0x03
MII_PHYSID1 and MII_PHYSID2
Please go through all these #defines and replace them with the
standard ones Linux provides. You are obfusticating the code by not
using what people already know.
Andrew
next prev parent reply other threads:[~2021-04-22 12:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 9:42 [PATCH v2 net-next 0/9] net: dsa: microchip: DSA driver support for LAN937x switch Prasanna Vengateshan
2021-04-22 9:42 ` [PATCH v2 net-next 1/9] dt-bindings: net: dsa: dt bindings for microchip lan937x Prasanna Vengateshan
2021-04-22 15:30 ` Rob Herring
2021-04-22 17:38 ` Rob Herring
2021-04-26 4:05 ` Prasanna Vengateshan
2021-04-26 16:04 ` Florian Fainelli
2021-04-22 9:42 ` [PATCH v2 net-next 2/9] net: phy: Add support for LAN937x T1 phy driver Prasanna Vengateshan
2021-04-22 12:45 ` Andrew Lunn [this message]
2021-04-26 4:06 ` Prasanna Vengateshan
2021-04-22 9:42 ` [PATCH v2 net-next 3/9] net: dsa: tag_ksz: add tag handling for Microchip LAN937x Prasanna Vengateshan
2021-04-22 19:18 ` Vladimir Oltean
2021-04-26 4:33 ` Prasanna Vengateshan
2021-04-26 12:27 ` Andrew Lunn
2021-04-22 9:42 ` [PATCH v2 net-next 4/9] net: dsa: microchip: add DSA support for microchip lan937x Prasanna Vengateshan
2021-04-22 19:59 ` Vladimir Oltean
2021-04-22 23:28 ` Andrew Lunn
2021-04-26 8:54 ` Prasanna Vengateshan
2021-04-26 12:34 ` Andrew Lunn
2021-04-27 7:43 ` Prasanna Vengateshan
2021-04-22 23:32 ` Andrew Lunn
2021-04-22 23:38 ` Andrew Lunn
2021-04-22 23:43 ` Andrew Lunn
2021-04-22 9:42 ` [PATCH v2 net-next 5/9] net: dsa: microchip: add support for phylink management Prasanna Vengateshan
2021-04-22 20:05 ` Vladimir Oltean
2021-04-22 9:42 ` [PATCH v2 net-next 6/9] net: dsa: microchip: add support for ethtool port counters Prasanna Vengateshan
2021-04-22 9:42 ` [PATCH v2 net-next 7/9] net: dsa: microchip: add support for port mirror operations Prasanna Vengateshan
2021-04-22 20:11 ` Vladimir Oltean
2021-04-22 9:42 ` [PATCH v2 net-next 8/9] net: dsa: microchip: add support for fdb and mdb management Prasanna Vengateshan
2021-04-22 9:42 ` [PATCH v2 net-next 9/9] net: dsa: microchip: add support for vlan operations Prasanna Vengateshan
2021-04-22 19:03 ` Vladimir Oltean
2021-05-06 14:51 ` Prasanna Vengateshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIFv9Wcp94395Hbb@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=prasanna.vengateshan@microchip.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).