From: Matthias Kaehlcke <mka@chromium.org>
To: Rajeshwari <rkambl@codeaurora.org>
Cc: amitk@kernel.org, thara.gopinath@linaro.org, agross@kernel.org,
bjorn.andersson@linaro.org, rui.zhang@intel.com,
daniel.lezcano@linaro.org, robh+dt@kernel.org,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
sanm@codeaurora.org
Subject: Re: [PATCH V1 2/2] dt-bindings: thermal: tsens: Add configuration in yaml
Date: Thu, 22 Apr 2021 10:45:05 -0700 [thread overview]
Message-ID: <YIG2IckKRBHqzpu3@google.com> (raw)
In-Reply-To: <1619005442-16485-3-git-send-email-rkambl@codeaurora.org>
On Wed, Apr 21, 2021 at 05:14:02PM +0530, Rajeshwari wrote:
> Subject: dt-bindings: thermal: tsens: Add configuration in yaml
This subject isn't really useful. The fact that the format of the
binding is yaml is irrelevant here. What is important is that you
are adding the compatible string for the SC7280 to the TSENS
binding. This should be reflected in the subject.
Also this is patch [2/2] and patch [1/2] adds DT entries with the new
compatible string. The binding should be defined before adding new
entries, hence the order of the patches should be inversed.
prev parent reply other threads:[~2021-04-22 17:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 11:44 [PATCH V1 0/2] ARM: dts: qcom: Add device node support for TSENS in SC7280 Rajeshwari
2021-04-21 11:44 ` [PATCH V1 1/2] ARM: dts: qcom: Add device node support for TSENS in Rajeshwari
2021-04-22 17:38 ` Matthias Kaehlcke
2021-04-21 11:44 ` [PATCH V1 2/2] dt-bindings: thermal: tsens: Add configuration in yaml Rajeshwari
2021-04-22 17:45 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIG2IckKRBHqzpu3@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rkambl@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sanm@codeaurora.org \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).