From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5194DC43460 for ; Wed, 5 May 2021 14:46:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28161613C7 for ; Wed, 5 May 2021 14:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230249AbhEEOrM (ORCPT ); Wed, 5 May 2021 10:47:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233309AbhEEOrM (ORCPT ); Wed, 5 May 2021 10:47:12 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91287C061574 for ; Wed, 5 May 2021 07:46:14 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id m11so2097619pfc.11 for ; Wed, 05 May 2021 07:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=R3G9d6KOWzFUMXwhCG8q7hRyP7veP3KVpL+M9wYJbzo=; b=c4wvDnRm+0PADdN/g8sRlbYeAI01jJiOp1ppnQsFnTtAoVcxvHMRzVuQoOXVIVhKlg JlGpfPPm/lnb/GqYZg0D/dn3IYX+jLYkO/dm8Jfsnwwd1G5VmFMGa41gnW3pPm98FtQm UiacgkrTdhaMBhE/fUwEIOet2ueOwZTVqSoT4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=R3G9d6KOWzFUMXwhCG8q7hRyP7veP3KVpL+M9wYJbzo=; b=nr1oEdGCxMOIZocRA9rVtilsHQSTU1jmuBCChZ1YIU5o6a+nWzPUUF83NUPhTuX+Zc 4xFWXE0okDBZT6brcrGPzFM3YCd92MLRQk2Le9SyQQCX/dGrgAoH+LI8zyuUhIMEL8pG UpPEu5Pr0iu+gk/bNjhneiGeXHFoKcKIIil+zxskYKQYYRha9TUBdr7sO4NqSwQiFb8O 3InoUfsO16boyp6ib0HFie2r8GpuqVRNuJS5yptgp34Se6KwsJC5u8MJN7Nja9+PNbZB v711fGNxSYrQoy111mV4BIqoB2aObkLy1ep+u1TOXnUgixDHItUxyxJaiup4jMmpQN+P jS0A== X-Gm-Message-State: AOAM531uNOEVD0zAn4EYReKcxxHRq7HuQ4VSAIbPp+Q2Mgm8UARUMIk+ 9vpjjpadQdfxzdeYr+nlMmtAWw== X-Google-Smtp-Source: ABdhPJzlkjo9Y9GoLDeR2gcRvMHn0sFqCyFftBjSk5qnwGnWJ9iqXeky2WsRfLuYXq8GFYxq02k7tA== X-Received: by 2002:aa7:9108:0:b029:251:7caf:cec with SMTP id 8-20020aa791080000b02902517caf0cecmr28828386pfh.13.1620225974050; Wed, 05 May 2021 07:46:14 -0700 (PDT) Received: from localhost ([2620:15c:202:201:8770:f856:b2ff:e5e4]) by smtp.gmail.com with UTF8SMTPSA id z23sm7026954pgj.56.2021.05.05.07.46.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 May 2021 07:46:13 -0700 (PDT) Date: Wed, 5 May 2021 07:46:12 -0700 From: Matthias Kaehlcke To: satya priya Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kgunda@codeaurora.org Subject: Re: [PATCH V4 7/8] arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp Message-ID: References: <1620197726-23802-1-git-send-email-skakit@codeaurora.org> <1620197726-23802-8-git-send-email-skakit@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1620197726-23802-8-git-send-email-skakit@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, May 05, 2021 at 12:25:25PM +0530, satya priya wrote: > Subject: arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp nit: just 'channel nodes' is a bit vague. In case you respin maybe change it to something like 'Add ADC channel nodes for PMIC temperatures to sc7280-idp' In any case it doesn't seem worth to respin just for this. > > Add channel nodes for the on die temperatures of PMICS > pmk8350, pm8350, pmr735a and pmr735b. > > Signed-off-by: satya priya Reviewed-by: Matthias Kaehlcke