From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC8AC433B4 for ; Fri, 7 May 2021 08:02:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD41761426 for ; Fri, 7 May 2021 08:02:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232868AbhEGIDK (ORCPT ); Fri, 7 May 2021 04:03:10 -0400 Received: from muru.com ([72.249.23.125]:52608 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232729AbhEGIDK (ORCPT ); Fri, 7 May 2021 04:03:10 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1A4F180E0; Fri, 7 May 2021 08:02:05 +0000 (UTC) Date: Fri, 7 May 2021 11:02:00 +0300 From: Tony Lindgren To: Naresh Kamboju Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkft-triage@lists.linaro.org, Linux ARM , Linux-OMAP , regressions@lists.linux.dev, Benoit Cousson , Kishon Vijay Abraham I , Vignesh Raghavendra , Viresh Kumar , Rob Herring Subject: Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata") Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * Naresh Kamboju [210506 15:19]: > On Thu, 6 May 2021 at 17:23, Tony Lindgren wrote: > > > > Hi, > > > > * Naresh Kamboju [210506 11:00]: > > > Our bisect script pointed this as the first bad commit on linux > > > mainline master branch. > > > > > > Full test log: > > > ---------------- > > > SATA detection failed log link, > > > https://lkft.validation.linaro.org/scheduler/job/2580998#L1973 > > > > > > -- > > > commit 98feab31ac491400f28b76a04dabd18ce21e91ba > > > Author: Tony Lindgren > > > Date: Wed Mar 10 14:03:51 2021 +0200 > > > > > > ARM: OMAP2+: Drop legacy platform data for dra7 sata > > > > Thanks for the report, looks like we are now missing the sata related > > quirk flags compared to the patch above. > > > > Below is a quick patch to add the missing quirk flags that might help > > if you can give it a try. > > The reported problem was solved by this patch. Thank you. > Please add reported and tested by tags. > > Reported-by: Naresh Kamboju > Tested-by: Naresh Kamboju OK good to hear and thanks for testing. Will send out a proper patch. Regards, Tony > > 8< -------------------------- > > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c > > --- a/drivers/bus/ti-sysc.c > > +++ b/drivers/bus/ti-sysc.c > > @@ -1459,6 +1459,8 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = { > > SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY), > > SYSC_QUIRK("tptc", 0, 0, -ENODEV, -ENODEV, 0x40007c00, 0xffffffff, > > SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY), > > + SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff, > > + SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY), > > SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, 0x14, 0x50700100, 0xffffffff, > > SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY), > > SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, -ENODEV, 0x50700101, 0xffffffff, > > @@ -1524,7 +1526,6 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = { > > SYSC_QUIRK("prcm", 0, 0, -ENODEV, -ENODEV, 0x40000400, 0xffffffff, 0), > > SYSC_QUIRK("rfbi", 0x4832a800, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0), > > SYSC_QUIRK("rfbi", 0x58002000, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0), > > - SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff, 0), > > SYSC_QUIRK("scm", 0, 0, 0x10, -ENODEV, 0x40000900, 0xffffffff, 0), > > SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4e8b0100, 0xffffffff, 0), > > SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4f000100, 0xffffffff, 0), > > -- > > 2.31.1 > > > Tested full log, > https://lkft.validation.linaro.org/scheduler/job/2641881#L1940 > > - Naresh