From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD0DC433ED for ; Tue, 11 May 2021 07:21:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 977C461353 for ; Tue, 11 May 2021 07:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229952AbhEKHWk (ORCPT ); Tue, 11 May 2021 03:22:40 -0400 Received: from mga14.intel.com ([192.55.52.115]:1879 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229871AbhEKHWj (ORCPT ); Tue, 11 May 2021 03:22:39 -0400 IronPort-SDR: 8x4j/ik5IKCjtkGBqSKJbMY5ixRGn+9ZRFH3Ngrg6/iCNnnufMxm9PzkofFKFwDpjzw3Mor0P/ DNFC8ZyQ1zOQ== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="199054412" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="199054412" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 00:21:34 -0700 IronPort-SDR: iJYINuSqGpL4F1giBSzzS2yjgLLuhmyhgi3UOoV7k0GlxYEkFCZzjYx+9Ib+L+3rHrgDAOapEj LsWjVBbAzSAw== X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="468722384" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 00:21:31 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lgMhr-00BNKa-49; Tue, 11 May 2021 10:21:27 +0300 Date: Tue, 11 May 2021 10:21:27 +0300 From: Andy Shevchenko To: Stephan Gerhold Cc: =?utf-8?Q?Ond=C5=99ej?= Jirman , Dmitry Torokhov , linux-input@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Simon Budig , Marco Felsch Subject: Re: [PATCH v2 2/2] Input: edt-ft5x06 - add support for iovcc-supply Message-ID: References: <20210510193108.50178-1-stephan@gerhold.net> <20210510193108.50178-2-stephan@gerhold.net> <20210510194848.g7cgty3lirxkht5g@core> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, May 10, 2021 at 10:16:41PM +0200, Stephan Gerhold wrote: > On Mon, May 10, 2021 at 09:48:48PM +0200, Ondřej Jirman wrote: ... > The reasons were: > > - Bulk regulator API: AFAICT there is no way to use it while also > maintaining the correct enable/disable order plus the 10us delay. > See https://lore.kernel.org/linux-input/X%2Fwj+bxe%2FIlznCj6@gerhold.net/ This by the way can be fixed on regulator level (adding some like ranges into bulk structure with timeouts, and if 0, skip them). > - dev_err_probe(): For some reason the patch set that converted a lot of > input drivers (including edt-ft5x06) to dev_err_probe() was never applied: > https://lore.kernel.org/linux-input/20200827185829.30096-12-krzk@kernel.org/ > I dropped the change from my patch since Andy already mentioned > a similar thing back then. This question to Dmitry, because I don't remember any good argument why he doesn't like it. Maybe he can refresh our memories by providing it again. -- With Best Regards, Andy Shevchenko