From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <devicetree-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 45594C47089
	for <linux-devicetree@archiver.kernel.org>; Thu, 27 May 2021 09:09:27 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 1D1AB61355
	for <linux-devicetree@archiver.kernel.org>; Thu, 27 May 2021 09:09:27 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235538AbhE0JK7 (ORCPT
        <rfc822;linux-devicetree@archiver.kernel.org>);
        Thu, 27 May 2021 05:10:59 -0400
Received: from muru.com ([72.249.23.125]:60950 "EHLO muru.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S235475AbhE0JK6 (ORCPT <rfc822;devicetree@vger.kernel.org>);
        Thu, 27 May 2021 05:10:58 -0400
Received: from atomide.com (localhost [127.0.0.1])
        by muru.com (Postfix) with ESMTPS id F289180A8;
        Thu, 27 May 2021 09:09:29 +0000 (UTC)
Date:   Thu, 27 May 2021 12:09:21 +0300
From:   Tony Lindgren <tony@atomide.com>
To:     Grygorii Strashko <grygorii.strashko@ti.com>
Cc:     Gowtham Tammana <g-tammana@ti.com>, Suman Anna <s-anna@ti.com>,
        bcousson@baylibre.com, robh+dt@kernel.org,
        linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Nisanth Menon <nm@ti.com>
Subject: Re: [PATCH v3] ARM: dts: dra7: Fix duplicate USB4 target module node
Message-ID: <YK9hwV8DaC+d4OvV@atomide.com>
References: <20210526213035.15448-1-g-tammana@ti.com>
 <YK8ykeNA9AsjB89I@atomide.com>
 <bd903d6a-2894-fc39-e431-5dfed04a3604@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bd903d6a-2894-fc39-e431-5dfed04a3604@ti.com>
Precedence: bulk
List-ID: <devicetree.vger.kernel.org>
X-Mailing-List: devicetree@vger.kernel.org

* Grygorii Strashko <grygorii.strashko@ti.com> [210527 09:03]:
> On 27/05/2021 08:48, Tony Lindgren wrote:
> > But let's keep the target-module@140000 here as it puts it in the right
> > location rather than directly on the ocp. Let's mark it with
> > status = "disabled" in dra7-l4.dtsi, and add a comment noting it's only
> > available on dra74x. So similar to what you had in your v1 patch, except
> > disabled.
> 
> My preference would be not to mix SoC variant specific modules in common module,
> and fix dra74x instead by placing usb4 node in proper place:
> 
> &l4_per3 {						/* 0x48800000 */
> 	segment@0 {	
> -->

Yeah that's even better, and leaves out status = "disabled".
Sounds good to me.

Regards,

Tony