From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 206FFC4707F for ; Thu, 27 May 2021 10:21:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0D61613E6 for ; Thu, 27 May 2021 10:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236118AbhE0KWq (ORCPT ); Thu, 27 May 2021 06:22:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:50854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236109AbhE0KWq (ORCPT ); Thu, 27 May 2021 06:22:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 87278613B5; Thu, 27 May 2021 10:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622110872; bh=vgyzIt6CtN9vLG6Di+ovSQQxvs1QgUK+S4mPaEabHmA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=11+uRWoCllq7Babz/VF18cY/kKDxCKFgkGSjDh68G44Jb6/e3LUJZ5WFljAf0LdK7 Vg1Hv4/n6craKsTv+bNZY8Xz8cbt4XMnZuvJ4y3i4+VMx1sCfLqv31O9Wq34WhTPul SxuvcYKOrykqNZMF7Fz1Q7Xf1MbxFy2xd6Q6VKKc= Date: Thu, 27 May 2021 12:21:09 +0200 From: Greg KH To: Kyle Tso Cc: heikki.krogerus@linux.intel.com, robh+dt@kernel.org, badhri@google.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] dt-bindings: connector: Replace BIT macro with generic bit ops Message-ID: References: <20210527101345.569725-1-kyletso@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210527101345.569725-1-kyletso@google.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, May 27, 2021 at 06:13:45PM +0800, Kyle Tso wrote: > BIT macro is not supported in dt-bindings. Replace it with generic bit > operations. Why isn't the BIT macro supported there? How are we going to "remember" that I should not take patches that use this #define in that location? thanks, greg k-h