From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97BAC433B4 for ; Thu, 20 May 2021 13:42:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2992611AD for ; Thu, 20 May 2021 13:42:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237927AbhETNnY (ORCPT ); Thu, 20 May 2021 09:43:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239828AbhETNmu (ORCPT ); Thu, 20 May 2021 09:42:50 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FA5FC06138D for ; Thu, 20 May 2021 06:41:26 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id b15-20020a17090a550fb029015dad75163dso5316300pji.0 for ; Thu, 20 May 2021 06:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lCDY3zqYN0TPm8XTDIr+feSz7CGQpYBusVmFxZWqbvU=; b=aYWpmcG5UzZYC+GcETZKyG/HHk9fPzAE6LU8/INOkQM5UZ1Yhm8j3OhGzZW0NjogHI q6fDF14+qqS3G+/gwiAo1S32FwPnRb/jZ5dOYjR720kR4CywTZk3la+dZv9d+wZcsSTN OBVzV8pjjA1u/jk4Ut+OypKVCJjV7ozSUeMhM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lCDY3zqYN0TPm8XTDIr+feSz7CGQpYBusVmFxZWqbvU=; b=B131Kqu08EA+Bx28eUKqyH2l4lXyLJEGqpQiDi19OJnzmuGX2rDGikKpaO1/WjXXrF PsqQTDG15Aobwcv7oMIyBVpVlxMQGJ9KaBz183LFEEXopUhK56bUwJlibzRyBuitW16m pwlicnK7IpXieI0uXjCddKnqMIosZXYx5jlnV4kEuPS/15tbbvczpwTO7xQJ4AC4J29K Iag6w0mtXwDesyu4/HpJvTUJVllsrEgLAw7naNw1P+M91AYIogFbBX0ejVa4JTqFK+Da N27pXqOs7lrSydpdFFni68Qaj7rKuWT14XrBgAEat8t01CnaQwxf9fjiTCVyAja1bViv 68WA== X-Gm-Message-State: AOAM532d6wnfDEOrsuchQtLVdPhGbGkeOQU4/bDfaik/mW2Yxv29/JEa b21d1z0Ikb/gk+UCmxz1JC3Ttw== X-Google-Smtp-Source: ABdhPJxIYFp3eVKeAwRaBfZhep5/uA8j/WMPoEzhG5E+LYHkc9EzY3M3ZpacSfZlKO4VgWPceDGyhg== X-Received: by 2002:a17:903:189:b029:f1:d67a:5168 with SMTP id z9-20020a1709030189b02900f1d67a5168mr5966517plg.82.1621518085625; Thu, 20 May 2021 06:41:25 -0700 (PDT) Received: from localhost ([2620:15c:202:201:3d5d:d560:9fb4:d9d1]) by smtp.gmail.com with UTF8SMTPSA id k21sm2111284pgb.56.2021.05.20.06.41.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 May 2021 06:41:25 -0700 (PDT) Date: Thu, 20 May 2021 06:41:23 -0700 From: Matthias Kaehlcke To: Alan Stern Cc: Greg Kroah-Hartman , Rob Herring , Frank Rowand , Michal Simek , devicetree@vger.kernel.org, Douglas Anderson , linux-usb@vger.kernel.org, Peter Chen , linux-kernel@vger.kernel.org, Stephen Boyd , Ravi Chandra Sadineni , Krzysztof Kozlowski , Bastien Nocera , Al Cooper , "Alexander A. Klimov" , Masahiro Yamada Subject: Re: [PATCH v10 2/5] USB: misc: Add onboard_usb_hub driver Message-ID: References: <20210511225223.550762-1-mka@chromium.org> <20210511155152.v10.2.I7c9a1f1d6ced41dd8310e8a03da666a32364e790@changeid> <20210518194511.GA1137841@rowland.harvard.edu> <20210519144356.GB1165692@rowland.harvard.edu> <20210520020521.GB1186755@rowland.harvard.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210520020521.GB1186755@rowland.harvard.edu> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, May 19, 2021 at 10:05:21PM -0400, Alan Stern wrote: > On Wed, May 19, 2021 at 04:07:17PM -0700, Matthias Kaehlcke wrote: > > On Wed, May 19, 2021 at 10:43:56AM -0400, Alan Stern wrote: > > > On Tue, May 18, 2021 at 02:40:47PM -0700, Matthias Kaehlcke wrote: > > > > > > > > Could you also have a look at "[4/5] usb: host: xhci-plat: > > > > Create platform device for onboard hubs in probe()" > > > > (https://lore.kernel.org/patchwork/patch/1425453/)? It's a > > > > relatively short patch that creates the platform device for > > > > the driver from xhci-plat as you suggested in the v4 > > > > discussion. > > > > > > I'm not the maintainer for xhci-related drivers. > > > > > > However, there is at least one thing about this patch which looks > > > suspicious: Adding the onboard_hub_dev pointer to struct usb_hcd instead > > > of to struct xhci_plat_priv, where it would make a lot more sense. > > > > I can move it to struct usb_hcd if that's preferred > > Thinko: The patch already has it in struct usb_hcd. I suggested moving > it to struct xhci_plat_priv. Ah, didn't actively recall to which struct I added it to, it has been a while since I wrote that patch ;-) Agreed that struct xhci_plat_priv is a better place.