From: Matthias Kaehlcke <mka@chromium.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
linux-usb@vger.kernel.org, Peter Chen <peter.chen@kernel.org>,
linux-kernel@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
Ravi Chandra Sadineni <ravisadineni@chromium.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bastien Nocera <hadess@hadess.net>,
Al Cooper <alcooperx@gmail.com>,
"Alexander A. Klimov" <grandmaster@al2klimov.de>,
Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH v10 2/5] USB: misc: Add onboard_usb_hub driver
Date: Thu, 20 May 2021 14:14:15 -0700 [thread overview]
Message-ID: <YKbRJylHrDiuSRGH@google.com> (raw)
In-Reply-To: <YKZnA2bifn346bPa@google.com>
On Thu, May 20, 2021 at 06:41:23AM -0700, Matthias Kaehlcke wrote:
> On Wed, May 19, 2021 at 10:05:21PM -0400, Alan Stern wrote:
> > On Wed, May 19, 2021 at 04:07:17PM -0700, Matthias Kaehlcke wrote:
> > > On Wed, May 19, 2021 at 10:43:56AM -0400, Alan Stern wrote:
> > > > On Tue, May 18, 2021 at 02:40:47PM -0700, Matthias Kaehlcke wrote:
> > > > >
> > > > > Could you also have a look at "[4/5] usb: host: xhci-plat:
> > > > > Create platform device for onboard hubs in probe()"
> > > > > (https://lore.kernel.org/patchwork/patch/1425453/)? It's a
> > > > > relatively short patch that creates the platform device for
> > > > > the driver from xhci-plat as you suggested in the v4
> > > > > discussion.
> > > >
> > > > I'm not the maintainer for xhci-related drivers.
> > > >
> > > > However, there is at least one thing about this patch which looks
> > > > suspicious: Adding the onboard_hub_dev pointer to struct usb_hcd instead
> > > > of to struct xhci_plat_priv, where it would make a lot more sense.
> > >
> > > I can move it to struct usb_hcd if that's preferred
> >
> > Thinko: The patch already has it in struct usb_hcd. I suggested moving
> > it to struct xhci_plat_priv.
>
> Ah, didn't actively recall to which struct I added it to, it has been a
> while since I wrote that patch ;-)
> Agreed that struct xhci_plat_priv is a better place.
Or not, xhci_plat_priv is optional, which doesn't make it a good candidate
for holding a field that could be used by any xHCI controller.
Should I move the field to struct xhci_hcd instead?
next prev parent reply other threads:[~2021-05-20 21:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 22:52 [PATCH v10 0/5] USB: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2021-05-11 22:52 ` [PATCH v10 1/5] dt-bindings: usb: Add binding for Realtek RTS5411 hub controller Matthias Kaehlcke
2021-05-11 22:52 ` [PATCH v10 2/5] USB: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2021-05-18 17:05 ` Matthias Kaehlcke
2021-05-18 19:45 ` Alan Stern
2021-05-18 21:40 ` Matthias Kaehlcke
2021-05-19 5:06 ` Greg Kroah-Hartman
2021-05-19 14:43 ` Alan Stern
2021-05-19 23:07 ` Matthias Kaehlcke
2021-05-20 2:05 ` Alan Stern
2021-05-20 13:41 ` Matthias Kaehlcke
2021-05-20 21:14 ` Matthias Kaehlcke [this message]
2021-05-21 1:14 ` Alan Stern
2021-05-25 17:20 ` Matthias Kaehlcke
2021-05-11 22:52 ` [PATCH v10 3/5] of/platform: Add stubs for of_platform_device_create/destroy() Matthias Kaehlcke
2021-05-11 22:52 ` [PATCH v10 4/5] usb: host: xhci-plat: Create platform device for onboard hubs in probe() Matthias Kaehlcke
2021-05-11 22:52 ` [PATCH v10 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Matthias Kaehlcke
2021-05-12 7:19 ` [PATCH v10 0/5] USB: misc: Add onboard_usb_hub driver Alexander Dahl
2021-05-12 16:37 ` Matthias Kaehlcke
2021-05-21 12:30 ` Greg Kroah-Hartman
2021-05-25 17:42 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKbRJylHrDiuSRGH@google.com \
--to=mka@chromium.org \
--cc=alcooperx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=frowand.list@gmail.com \
--cc=grandmaster@al2klimov.de \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=peter.chen@kernel.org \
--cc=ravisadineni@chromium.org \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).