From: Tony Lindgren <tony@atomide.com>
To: Suman Anna <s-anna@ti.com>
Cc: Gowtham Tammana <g-tammana@ti.com>,
bcousson@baylibre.com, robh+dt@kernel.org,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Grygorii Strashko <grygorii.strashko@ti.com>,
Nisanth Menon <nm@ti.com>
Subject: Re: [PATCH] ARM: dts: DRA7x: Fix duplicate USB4 device node
Date: Tue, 25 May 2021 09:27:58 +0300 [thread overview]
Message-ID: <YKyY7mYkNCHIrgSm@atomide.com> (raw)
In-Reply-To: <9445e5c9-819c-0aed-f96f-b1ac2ea7d13e@ti.com>
* Suman Anna <s-anna@ti.com> [210524 15:24]:
> This can be fixed in couple of different ways, and I see there have been
> different commits that have ultimately caused this.
> 6b14eb4705d6 ("ARM: dts: DRA7: Move USB_OTG 4 to dra74x.dtsi")
> 549fce068a31 ("ARM: dts: dra7: Add l4 interconnect hierarchy and ti-sysc data"
> bcbb63b80284 (ARM: dts: dra7: Separate AM57 dtsi files")
> c7b72abca61e ("ARM: OMAP2+: Drop legacy platform data for dra7 dwc3")
>
> Would you prefer that we just drop the USB4 target-module reference in
> dra7-l4.dtsi following the first commit?
Looking at commit 549fce068a31 above, we have dra7-l4.dtsi define a module
at 0x48940000. But maybe the module is only used for dwc on dra74x?
If this controller instance is on all dra7 SoCs, then it should be in
dra7-l4.dtsi. If the controller instance is only on dra74x, it should be
only in dra74x.dtsi file.
Sorry sounds like I have confused some hardware differences along the
way.
Regards,
Tony
next prev parent reply other threads:[~2021-05-25 6:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 21:18 [PATCH] ARM: dts: DRA7x: Fix duplicate USB4 device node Gowtham Tammana
2021-05-24 15:24 ` Suman Anna
2021-05-25 6:27 ` Tony Lindgren [this message]
2021-05-26 17:23 ` [EXTERNAL] " Tammana, Gowtham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKyY7mYkNCHIrgSm@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=g-tammana@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).