From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B5D0C47082 for ; Tue, 8 Jun 2021 22:27:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2175A6128A for ; Tue, 8 Jun 2021 22:27:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232742AbhFHW3g (ORCPT ); Tue, 8 Jun 2021 18:29:36 -0400 Received: from mail-oi1-f174.google.com ([209.85.167.174]:46999 "EHLO mail-oi1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231208AbhFHW3f (ORCPT ); Tue, 8 Jun 2021 18:29:35 -0400 Received: by mail-oi1-f174.google.com with SMTP id c13so17606417oib.13 for ; Tue, 08 Jun 2021 15:27:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zEVt4/c8lCCNqBGSoq0YIzdJWJUhrx9cSDWBmiuwl3Q=; b=NH6AZogFTIQAehx/IPJIZOXHKcbR97a4hXmH6UkB/RAObPSx36Jr3192QR5zz0LElg f2CIKAXSbtyBoOLzBhMxymkjtlX1xv7CdXR2AgWkLMnKsbKGOeKJqo+qy2fW7eDeSUZ+ nLly6tGwsNWtUB8HIjIcNqDOT6mkTyoR+vQu5zqDpnKOmfrmvwovSdrK5AUE7M/UwocU UO5jq+xGroaF9jYF3IPq1uU8QDyxsMTJFzG9YH9TgOCpJtZdwzXpjUoZDILJr4/RQwi+ JEo4j79a8NqXyDatfB+zWaCMe6wVX6qMzibu7XI+H7KAg/TFN8sgiKphtClFLqbgLzMi L2kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zEVt4/c8lCCNqBGSoq0YIzdJWJUhrx9cSDWBmiuwl3Q=; b=hq3c3mM5Yh8Eumml0epC/UEDPjxSy1WktxYCTimaNaktbJbUGQLkhApMtN4tLnAaXH 67oNwhY2xsfDpofYN9q5XPxtAiXQfALy7u3J3cQrMKKjFndItsqOOLLll+R3rW+VpAu5 RgE8SYGzfXLzHaqaqnuEPcmC9XJ+9IPB7WUU86FyhPq9sYW5sltf29tBr2hBImERn6bt QVPT56BmmA2ixkrTFg9VjXjD6MkhnD3TipuKjORWAmNkgVX2sBQi71PAug7Ya4i2vy7Z qCysaCLBlbj9Laq+bvuC1gRlTW6F1kCXx3IPAeDDERRgmZLcEKJ5/8gj/TXFdhBw9bz9 Jl2A== X-Gm-Message-State: AOAM532y1xjmnkrjehOaQaZ/j1j9Dzcz4oif5Uas1Pbts/+9wDKO6Mcu Eony4VVbJbLguIWG3o/gVBt2pbnfDDKKgA== X-Google-Smtp-Source: ABdhPJwwPivLBLTPZZXHggklQbT8BkpioImdV/IT0T25YTOA/Wz8xXB2krv/o5SVJGfYlXTG8jaLQQ== X-Received: by 2002:a05:6808:195:: with SMTP id w21mr2463312oic.7.1623191186987; Tue, 08 Jun 2021 15:26:26 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id f25sm1043989oto.26.2021.06.08.15.26.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jun 2021 15:26:26 -0700 (PDT) Date: Tue, 8 Jun 2021 17:26:23 -0500 From: Bjorn Andersson To: Stephen Boyd Cc: khsieh@codeaurora.org, robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org, agross@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, abhinavk@codeaurora.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node Message-ID: References: <1622736555-15775-1-git-send-email-khsieh@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue 08 Jun 17:15 CDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-06-07 16:31:47) > > On Mon 07 Jun 12:48 CDT 2021, khsieh@codeaurora.org wrote: > > > > > On 2021-06-05 22:07, Bjorn Andersson wrote: > > > > On Thu 03 Jun 16:56 CDT 2021, khsieh@codeaurora.org wrote: > > > > > > > > > On 2021-06-03 09:53, Bjorn Andersson wrote: > > > > > > On Thu 03 Jun 11:09 CDT 2021, Kuogee Hsieh wrote: > > > > [..] > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > > > [..] > > > > > > > + power-domains = <&rpmhpd SC7180_CX>; > > > > > > > > > > > > Just curious, but isn't the DP block in the MDSS_GDCS? Or do we need to > > > > > > mention CX here in order for the opp framework to apply required-opps > > > > > > of CX? > > > > > > > > > > yes, > > > > > > > > If you want me, or other maintainers, to spend any time reviewing or > > > > applying your patches going forward then you need to actually bother > > > > replying properly to the questions asked. > > > > > > > > Thanks, > > > > Bjorn > > > > > > Sorry about the confusion. What I meant is that even though DP controller is > > > in the MDSS_GDSC > > > power domain, DP PHY/PLL sources out of CX. The DP link clocks have a direct > > > impact > > > on the CX voltage corners. Therefore, we need to mention the CX power domain > > > here. And, since > > > we can associate only one OPP table with one device, we picked the DP link > > > clock over other > > > clocks. > > > > Thank you, that's a much more useful answer. > > > > Naturally I would think it would make more sense for the PHY/PLL driver > > to ensure that CX is appropriately voted for then, but I think that > > would result in it being the clock driver performing such vote and I'm > > unsure how the opp table for that would look. > > > > @Stephen, what do you say? > > > > Wouldn't the PHY be the one that sets some vote? So it wouldn't be the > clk driver, and probably not from the clk ops, but instead come from the > phy ops via phy_enable() and phy_configure(). > If I understand the logic correctly *_configure_dp_phy() will both configure the vco clock and "request" the clock framework to change the rate. So I presume what you're suggesting is that that would be the place to cast the CX corner vote? > By the way, there's nothing wrong with a clk device doing power domain > "stuff", except for that we haven't plumbed it into the clk framework > properly and I'm fairly certain our usage of runtime PM in the clk > framework today underneath the prepare_lock is getting us into trouble > or will get us there soon. On the bright side, it's wonderful that we're at a point where this is not only a theoretical problem :) Regards, Bjorn