From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E22BC47082 for ; Mon, 31 May 2021 17:05:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25E8161042 for ; Mon, 31 May 2021 17:05:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234008AbhEaRHL (ORCPT ); Mon, 31 May 2021 13:07:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232591AbhEaRFH (ORCPT ); Mon, 31 May 2021 13:05:07 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB61DC068FBE for ; Mon, 31 May 2021 08:16:50 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id 36-20020a9d0ba70000b02902e0a0a8fe36so11373166oth.8 for ; Mon, 31 May 2021 08:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eJ+dYMSuiwP1+9nN6hX9bLUsV2tE3Lu68y9sPFybEHo=; b=FBuH9Rsn1jK9JXcGAjt4pQtwU4I8YQY1NQlarypgBpZtskjQDIOvheGUUY6AFQsqVZ H1fpSHlDDPruTNjvMzwXMiioYIus/QZerzEoAqMjRZ3Lb5ymU1rGZTLhjxsHaiakboXJ 6rtoohTQyZPnU0tD4PZOId/v/V396D46+mYtQ3sW7TubAsL6fCftGrzilcCpAz904BEO vvYbTazYT6oBjoxNjKPAo7lPV7HgEtqlaeih0R+BJlTIHwROqVT4PxKLkUNW1DEMbg42 ARbtq/TP9RHm1YY6hF0YfE1k1Od+TOJDgwQKVLih74QziiSPp0G8v43a7DSy1zAlKNhY k8Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eJ+dYMSuiwP1+9nN6hX9bLUsV2tE3Lu68y9sPFybEHo=; b=RE6Jx8lVJT7gKaHVuA3XWYfs8Pt1sCiGcLje3OFMjaWeVzUBgZsWCT5UtngiYbhe+b zIkmifBEXePBqFe6r462OApEliuNqEC9qvmIpMKN8z34ZFx/U9VTmWn/mfdeRHvMQ2cd uz7khz91lJhpV7n0F1kPzTVdKz0GUDh9XbMk3ky7zdy3+kGsRirLH//YCiNXWrBZ1Rgo WbMI7sdAQwG2f444UoULW1hnnlVCzHrswSDR1jFwtTvaBPjIejGc9TOaLgfol+i4UBFK +PRTe6CDHhP1ZaCKX74oyTA6/nSK7vNOnL4Zq0KX8Zls+NfPtWsaLZBoFdTo42SKyrUm oJ0Q== X-Gm-Message-State: AOAM530JjHpeNoD9HpFYyD1teXTPTCbRKveICaX7iI47UnbsHCekhK/u MHVadFcaLBIPXwu1GSAO9bAyZA== X-Google-Smtp-Source: ABdhPJyGASUipnV6yOcgG/ZyPcO2IslIfjpRJlBl8OAgkcD4GJf/OyADC3dnUHK1WQyRdz/HaCTQ4A== X-Received: by 2002:a9d:6ace:: with SMTP id m14mr17167910otq.207.1622474210171; Mon, 31 May 2021 08:16:50 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id k20sm3169469otb.15.2021.05.31.08.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 08:16:49 -0700 (PDT) Date: Mon, 31 May 2021 10:16:47 -0500 From: Bjorn Andersson To: Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: Add support for SONY Xperia X Performance/XZ/XZs Message-ID: References: <20210527170409.667255-1-konrad.dybcio@somainline.org> <20210527170409.667255-3-konrad.dybcio@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210527170409.667255-3-konrad.dybcio@somainline.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu 27 May 12:04 CDT 2021, Konrad Dybcio wrote: > diff --git a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi [..] > +&pm8994_gpios { > + pinctrl-names = "default"; > + pinctrl-0 = <&pm8994_gpios_defaults>; > + gpio-line-names = > + "NC", > + "VOL_DOWN_N", > + "VOL_UP_N", > + "SNAPSHOT_N", > + "FOCUS_N", > + "NC", > + "NFC_VEN", > + "NC", > + "NC", > + "NC", > + "NC", > + "NC", > + "EAR_EN", > + "NC", > + "PM_DIVCLK1", > + "PMI_CLK", > + "NC", > + "WL_SLEEP_CLK", > + "NC", > + "PMIC_SPON", > + "UIM_BATT_ALARM", > + "PMK_SLEEP_CLK"; > + > + /* > + * We don't yet know for sure which GPIOs are of our interest, but what > + * we do know is that if a vendor sets the pins to a non-default state, there's > + * probably a reason for it, and just to be on the safe side, we follow suit. > + */ > + pm8994_gpios_defaults: pm8994-gpios-default-state { > + pm8994_gpio1_n: pm8994-gpio1-nc { Is there a reason for keeping pm8994_gpios_defaults? I presume you won't be able to select it, because the associated pins are already busy? > + pins = "gpio1"; > + function = PMIC_GPIO_FUNC_NORMAL; > + drive-push-pull; > + bias-high-impedance; > + }; > + [..] > +&pmi8994_gpios { > + pinctrl-names = "default"; > + pinctrl-0 = <&pmi8994_gpios_defaults>; > + > + gpio-line-names = > + "VIB_LDO_EN", > + "NC", > + "NC", > + "NC", > + "NC", > + "NC", > + "NC", > + "NC", > + "USB_SWITCH_SEL", > + "NC"; > + > + pmi8994_gpios_defaults: pmi8994-gpios-default-state { > + pmi8994_vib_ldo_en: vib-ldo-en-gpio { Ditto. > + pins = "gpio1"; > + function = PMIC_GPIO_FUNC_NORMAL; > + drive-push-pull; > + output-low; > + bias-disable; > + power-source = ; > + }; Regards, Bjorn