From: Andrew Lunn <andrew@lunn.ch>
To: Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
hkallweit1@gmail.com, linux@armlinux.org.uk,
f.fainelli@gmail.com, linux-imx@nxp.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] dt-bindings: net: add dt binding for realtek rtl82xx phy
Date: Wed, 2 Jun 2021 04:39:20 +0200 [thread overview]
Message-ID: <YLbvWKIE3FOhdzsl@lunn.ch> (raw)
In-Reply-To: <20210601090408.22025-2-qiangqing.zhang@nxp.com>
> +properties:
> + rtl821x,clkout-disable:
> + description: Disable CLKOUT clock.
> + type: boolean
> +
> + rtl821x,aldps-disable:
> + description: Disable ALDPS mode.
> + type: boolean
I think most of the problems are the ambiguity in the binding.
If rtl821x,clkout-disable is not present, should it enable the CLKOUT?
That needs clear define here.
Do we actually want a tristate here?
rtl821x,clkout = <true>;
means ensure the clock is outputting.
rtl821x,clkout = <false>;
means ensure the clock is not outputting.
And if the property is not in DT at all, leave the hardware alone, at
either its default value, or whatever came before has set it to?
Andrew
next prev parent reply other threads:[~2021-06-02 2:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 9:04 [PATCH net-next 0/4] net: phy: add dt property for realtek phy Joakim Zhang
2021-06-01 9:04 ` [PATCH net-next 1/4] dt-bindings: net: add dt binding for realtek rtl82xx phy Joakim Zhang
2021-06-01 13:32 ` Rob Herring
2021-06-02 2:39 ` Andrew Lunn [this message]
2021-06-02 3:14 ` Joakim Zhang
2021-06-01 9:04 ` [PATCH net-next 2/4] net: phy: realtek: add dt property to disable CLKOUT clock Joakim Zhang
2021-06-01 11:48 ` Russell King (Oracle)
2021-06-02 2:18 ` Joakim Zhang
2021-06-01 22:07 ` Andrew Lunn
2021-06-02 2:23 ` Joakim Zhang
2021-06-01 9:04 ` [PATCH net-next 3/4] net: phy: realteck: add dt property to disable ALDPS mode Joakim Zhang
2021-06-01 11:52 ` Russell King (Oracle)
2021-06-02 2:22 ` Joakim Zhang
2021-06-01 9:04 ` [PATCH net-next 4/4] net: phy: realtek: add delay to fix RXC generation issue Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLbvWKIE3FOhdzsl@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).