Re: [PATCH 0/6] iio: accel: bmc150: Add support for BMA253/BMA254

[Stephan Gerhold <stephan@gerhold.net>]

On Thu, Jun 10, 2021 at 01:51:22PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 10, 2021 at 1:48 PM Stephan Gerhold <stephan@gerhold.net> wrote:
> > On Thu, Jun 10, 2021 at 01:29:26PM +0300, Andy Shevchenko wrote:
> > > On Thu, Jun 10, 2021 at 12:56 PM Stephan Gerhold <stephan@gerhold.net> wrote:
> > > >
> > > > The Bosch BMA253 accelerometer is very similar to both BMA254 and BMA255.
> > > > The current situation is very confusing: BMA254 is supported by the bma180
> > > > driver, but BMA255 is supported by the bmc150-accel driver.
> > > >
> > > > It turns out the bma180 and bmc150-accel drivers have quite some overlap,
> > > > and BMA253/BMA254 would be a bit better supported in bmc150
> > > > (which has support for the motion trigger/interrupt).
> > > >
> > > > This series adds BMA253 support to bmc150-accel and also moves BMA254
> > > > over to bmc150, removing some unnecessary code from the bma180 driver.
> > > >
> > > > I asked Linus Walleij to test these patches on BMA254 a while ago
> > > > and he suggested that I already add his Reviewed-by.
> > >
> > > I add
> > >
> > >
> > > After addressing comments per patch 1, feel free to add my
> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > to the series.
> > >
> >
> > Thanks for the review!
> >
> > I think the re-ordering should be a separate commit to make the diff not
> > too confusing. Is it fine for you if I send that as a follow-up patch?
> > I already have two more patches that would conflict with the reordering,
> > so it would be easier to include that in the next series.
> >
> > But I can also re-send the entire series with the extra patch if you
> > prefer that, just let me know. :)
> 
> I think that doing the reordering first (if there are no fixes so far)
> is a good idea.
> 

OK, I will try to do that somehow. I will probably prepend one of my
additional patches to this series since it has a Fixes: tag that would
just cause the stable people headaches later when backporting.

Thanks,
Stephan