From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC3BBC47094 for ; Thu, 10 Jun 2021 13:01:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2F0D613F1 for ; Thu, 10 Jun 2021 13:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230378AbhFJNDD (ORCPT ); Thu, 10 Jun 2021 09:03:03 -0400 Received: from mo4-p03-ob.smtp.rzone.de ([85.215.255.100]:9383 "EHLO mo4-p03-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231133AbhFJNC7 (ORCPT ); Thu, 10 Jun 2021 09:02:59 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1623330057; cv=none; d=strato.com; s=strato-dkim-0002; b=KrSsON5uT1FtPXkvwp6dMEUOsejS4rCADVo+pVkw2xeLbk2FOxVTRVR7r7Y3zESPxE gJtKaD0sxbMurZCvcoWkjpFytd4IduDKD/HZGr6HNVhTsEs16vy6MrxCNvtNZ5OlF57v 6oOx94I3pQwp2LgX61feRUswMYwKv8UJ3I6KrUZSL4J2mp6XLmAN3Mgdm7ds4AD518jf PcmpqB1EA5a+P7tnMgbX7w41vcr4kx2pp0DJgvL4A68JMnTiyTF0Q2ZS0V9ghWLxW952 RtJbslJxlR02+9lW+yl7TrjLTBx/u7tbKm4AAIej0z9N7CLD1W3vBOEdO+pKIi6vFyNM yA7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1623330057; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=sWxhDLVjSdcZ2UQfDvOUeM8ckKd6tdu1RXGe2b5SbxA=; b=EYYMmZ/tfmHP0l+Z0vXHSDg3jx/Y32XMdAwYefQZHhWwxN09BkS+wiumHwK+THAk6h HP0NOG1MSSCUcByK0zVGxsPZPmATfLZuXxG7NLoKxbNp++cxlcxKQf4IZ1OfPAEjAxnT BixW1Uul/6mIQOJMihoC3q2uztkI6SyeCUkvR7H980C/iD76oAnrsWtKkTAm41uQ0x3s 1l/jhTHRiX9ZS/pFD03k+rAFIDc5xeKGGJEW8oTyhgHjVrBToNkBKjhb6sMQ2o09ncfe RBZUGyyZEWrr1LUEwboBN/+3ugjECWI2AKtn22o0zYM3HM1T5nzxVuGtRldF1xUSLHlK Em6g== ARC-Authentication-Results: i=1; strato.com; dkim=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1623330057; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=sWxhDLVjSdcZ2UQfDvOUeM8ckKd6tdu1RXGe2b5SbxA=; b=H2jrjcHXgiGUpEexIxYEfL3LUzAVtY12sPAr57SrHQpp0L4FKIDyKIhNhlHFNqz0t9 xasZpjHn3Rr2GGQywa+wuJvn+oO9RskoCFM7LbsTmwisA5zA66wLRFVePMJsVbmqu37B x4Rg9xNbi0lupI/jAf9dYdKuqjJ66aQQyqPeM9BBhzo07NRzSHO5EpxMGSgwyl4vtCLc zVXfQ3BRIIZA5VZdvVXU9f4zZ1+dxEzNJL/KGujroPI08DpTizCcCfMdE/OtlCi8vi52 HNhB/+W1GOJjIAYp2wvfzBIObzYQPPoILG7hDXU8cL5sDquLq+m/c/2aodJKb3G12cUh ic/w== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u26zEodhPgRDZ8nxIc/BaYo=" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 47.27.2 DYNA|AUTH) with ESMTPSA id y01375x5AD0vuGE (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 10 Jun 2021 15:00:57 +0200 (CEST) Date: Thu, 10 Jun 2021 15:00:52 +0200 From: Stephan Gerhold To: Andy Shevchenko Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Linus Walleij , Peter Meerwald , linux-iio , devicetree , Bastien Nocera , Hans de Goede , ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v2 4/9] iio: accel: bmc150: Sort all chip names alphabetically / by chip ID Message-ID: References: <20210610122126.50504-1-stephan@gerhold.net> <20210610122126.50504-5-stephan@gerhold.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 10, 2021 at 03:50:25PM +0300, Andy Shevchenko wrote: > On Thu, Jun 10, 2021 at 3:24 PM Stephan Gerhold wrote: > > > > Right now all the device IDs are listed in seemingly random order, > > make this consistent by ordering those alphabetically. Also, order > > bmc150_accel_chip_info_tbl by chip ID for the same reason. > > Thanks! > My comments below, after addressing them, > Reviewed-by: Andy Shevchenko > > ... > > > select BMC150_ACCEL_SPI if SPI > > help > > Say yes here to build support for the following Bosch accelerometers: > > - BMC150, BMI055, BMA250E, BMA222E, BMA255, BMA280. > > + BMA222, BMA222E, BMA250E, BMA255, BMA280, BMC150, BMI055. > > Thanks! > > > - This is a combo module with both accelerometer and magnetometer. > > > + BMC150 is a combo module with both accelerometer and magnetometer. > > BMC150 is only one from the list. Previous message applies to all > listed components, so is this not true anymore for the rest? > Or all the rest is not a combo? Please, clarify that in the commit > message, or if this is a wrong change, drop it. > I stumbled on that sentence when making the changes and it definitely does not apply to the BMA* variants. Those are accelerometer only. As far I can tell the prefix in the chip name says which kind of sensors are included, i.e. - BMC150: accelerometer + magnetometer - BMA*: only accelerometer I'm not familiar with BMI055 but funnily the datasheet suggests it's - BMI055: accelerometer + gyroscope So for BMI055 the previous message is wrong too. I guess I need to do yet another commit in v3 to make the Kconfig option more clear for all the sensor variants. :) Thanks! Stephan