From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB93C48BDF for ; Fri, 11 Jun 2021 03:02:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 882DD61040 for ; Fri, 11 Jun 2021 03:02:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231180AbhFKDD4 (ORCPT ); Thu, 10 Jun 2021 23:03:56 -0400 Received: from mail-ot1-f46.google.com ([209.85.210.46]:34794 "EHLO mail-ot1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231434AbhFKDDx (ORCPT ); Thu, 10 Jun 2021 23:03:53 -0400 Received: by mail-ot1-f46.google.com with SMTP id v27-20020a056830091bb02903cd67d40070so1820147ott.1 for ; Thu, 10 Jun 2021 20:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CMqzFHpL/T/3Mu7pEcAjimpE29cdfMEPiGJnXB3dZDc=; b=xhQjKJNC5QUacmFM0L5+he2v67mA+MyCRbRQb5hMJPhkXWUFJ2q+Aetkcuz9I8lkqM CjYP3omEYdZTQbyRdqY17ZHgQ+KcD4Z1iVvUTahlp81bwIoc5GXCTqT3c69Cs0zDfye2 Vtpdk+ymJNY4WaJ4tk+7xRbTWNRHBH9hUwmVL3j/t5dX9ILtFpiAJZvNhPcct4JrxoGO Bh5O2V6JPi7MRKgQfr1XNVCrqBqd1KkvbPYmnfB40ycx97NGLIVDA8g9sSb6WvhQn+55 Dy1aUSNyTyiEzPT4eC+rYLKx3uk1pgeZ6uBGK/bufNeGVS4p5OxoyhG+FZgnnc+7FNZW gx6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CMqzFHpL/T/3Mu7pEcAjimpE29cdfMEPiGJnXB3dZDc=; b=twzU2Dw1yDlttJxmmRimTqlIywjgKtVlKbKNncCW5ZACR3nHZ9flqR65G5qrW5JElS DwyNPGM8TOksHarjludz9R/uwn3FNWzgbCYVuU4Rtr87dXorGaD5B4BNWY+ZhsdQ6ZlM ecXoUzWXQDU/GPQ3BpS2sXhWKenqX5ghknLjjwAATY7pYCeFwW/bqalPn32VuUrxCjZJ K8ydn0/A+0+i5pH+fUfAr6ytjHf7pKok81VqBFaeOS9O14Tvi3wkg2iYQSiKZa9fPHN+ t4p9FWQ8RoQtE0BJw5eeBz61+crZKOf2ccnnIE7SQIX6gp96wf7g4Ld9ng9iywLY4Y0/ 8rPw== X-Gm-Message-State: AOAM533ZtvX2lYkeggMGyrD8f0ARFuPh7y6rsv5w384GtnGw6rFRKd0p 14OygmaO+urspqajPgyZs8i3Gw== X-Google-Smtp-Source: ABdhPJypjD1Lk3iNtELqDAcPXKCtM+oT3ko2EQNtyx0WUHMSXGYLlrUd6fnidHS8/EAyhn0NlqptwA== X-Received: by 2002:a05:6830:1d0:: with SMTP id r16mr1157644ota.116.1623380441709; Thu, 10 Jun 2021 20:00:41 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id q15sm921677oon.28.2021.06.10.20.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 20:00:41 -0700 (PDT) Date: Thu, 10 Jun 2021 22:00:39 -0500 From: Bjorn Andersson To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, Linus Walleij , Liam Girdwood , Mark Brown , Vinod Koul , Rob Herring , Andy Gross , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bhupesh.linux@gmail.com Subject: Re: [PATCH 5/8] pinctrl: qcom/pinctrl-spmi-gpio: Add compatibles for pmic-gpios on SA8155p-adp Message-ID: References: <20210607113840.15435-1-bhupesh.sharma@linaro.org> <20210607113840.15435-6-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210607113840.15435-6-bhupesh.sharma@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote: > SA8155p-adp PMICs (PMM8155AU_1 and PMM8155AU_2) expose > the following PMIC GPIO blocks: > > - PMM8155AU_1: gpio1-gpio10 (with holes on gpio2, gpio5, gpio7 and gpio8) > - PMM8155AU_2: gpio1-gpio10 (with holes on gpio2, gpio5, gpio7) > > Add support for the same in the pinctrl driver. > > Cc: Linus Walleij > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Bjorn Andersson > Cc: Vinod Koul > Cc: Rob Herring > Cc: Andy Gross > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-gpio@vger.kernel.org > Cc: bhupesh.linux@gmail.com > Signed-off-by: Bhupesh Sharma > --- > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > index 00870da0c94e..890c44b6e198 100644 > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > @@ -1127,6 +1127,10 @@ static const struct of_device_id pmic_gpio_of_match[] = { > { .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 }, > /* pm8150l has 12 GPIOs with holes on 7 */ > { .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 }, > + /* pmm8155au-1 has 10 GPIOs with holes on 2, 5, 7 and 8 */ > + { .compatible = "qcom,pmm8155au-1-gpio", .data = (void *) 10 }, As noted in the binding, I think this should be "qcom,pmm8155au-gpio" and please skip the comment about the holes. Thanks, Bjorn > + /* pmm8155au-2 has 10 GPIOs with holes on 2, 5 and 7 */ > + { .compatible = "qcom,pmm8155au-2-gpio", .data = (void *) 10 }, > { .compatible = "qcom,pm8350-gpio", .data = (void *) 10 }, > { .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 }, > { .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 }, > -- > 2.31.1 >