devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Prchal <jiri.prchal@aksignal.cz>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Christian Eggers <ceggers@arri.de>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v9 1/5] nvmem: prepare basics for FRAM support
Date: Fri, 11 Jun 2021 10:48:44 +0200	[thread overview]
Message-ID: <YMMjbCFzsfiT8dMA@kroah.com> (raw)
In-Reply-To: <20210611052652.7894-2-jiri.prchal@aksignal.cz>

On Fri, Jun 11, 2021 at 07:26:48AM +0200, Jiri Prchal wrote:
> Added enum and string for FRAM to expose it as "fram".

I have no idea what "FRAM" is, nor what "fram" is.

And why do you not add the documentation update here in this same
commit?  This is where you are adding it, trying to dig later in the
series to notice that you really did provide this is a pain, and is
harder to track.

Please provide more information here in the changelog and move the
Documentation addition here into this patch.

thanks,

greg k-h

  reply	other threads:[~2021-06-11  8:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11  5:26 [PATCH v9 0/5] add support for FRAM Jiri Prchal
2021-06-11  5:26 ` [PATCH v9 1/5] nvmem: prepare basics for FRAM support Jiri Prchal
2021-06-11  8:48   ` Greg Kroah-Hartman [this message]
2021-06-11  8:59     ` Jiří Prchal
2021-06-11  9:08       ` Greg Kroah-Hartman
2021-06-14 16:38     ` Enrico Weigelt, metux IT consult
2021-06-11  5:26 ` [PATCH v9 2/5] nvmem: eeprom: at25: add support for FRAM Jiri Prchal
2021-06-11  8:51   ` Greg Kroah-Hartman
2021-06-11  5:26 ` [PATCH v9 3/5] dt-bindings: nvmem: at25: add for FRAM support Jiri Prchal
2021-06-11  5:26 ` [PATCH v9 4/5] nvmem: eeprom: at25: export FRAM serial num Jiri Prchal
2021-06-11  8:52   ` Greg Kroah-Hartman
2021-06-11  5:26 ` [PATCH v9 5/5] nvmem: eeprom: add documentation of sysfs fram and sernum file Jiri Prchal
2021-06-11  8:53   ` Greg Kroah-Hartman
2021-06-11  9:01     ` Jiří Prchal
2021-06-11  9:07       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMMjbCFzsfiT8dMA@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=ceggers@arri.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jiri.prchal@aksignal.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).