public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Prchal <jiri.prchal@aksignal.cz>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Christian Eggers <ceggers@arri.de>, Arnd Bergmann <arnd@arndb.de>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] nvmem: eeprom: at25: fix type compiler warnings
Date: Fri, 11 Jun 2021 16:45:10 +0200	[thread overview]
Message-ID: <YMN29rIlPDCL0w3A@kroah.com> (raw)
In-Reply-To: <20210611142706.27336-1-jiri.prchal@aksignal.cz>

On Fri, Jun 11, 2021 at 04:27:06PM +0200, Jiri Prchal wrote:
> Fixes:
> drivers/misc/eeprom/at25.c:181:28: warning: field width should have type 'int',
> but argument has type 'unsigned long'
> 
> drivers/misc/eeprom/at25.c:386:13: warning: cast to smaller integer type 'int'
> from 'const void *'
> 
> Signed-off-by: Jiri Prchal <jiri.prchal@aksignal.cz>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
>  drivers/misc/eeprom/at25.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
> index 6e26de68a001..744f7abb22ee 100644
> --- a/drivers/misc/eeprom/at25.c
> +++ b/drivers/misc/eeprom/at25.c
> @@ -178,7 +178,7 @@ static ssize_t sernum_show(struct device *dev, struct device_attribute *attr, ch
>  	struct at25_data *at25;
>  
>  	at25 = dev_get_drvdata(dev);
> -	return sysfs_emit(buf, "%*ph\n", sizeof(at25->sernum), at25->sernum);
> +	return sysfs_emit(buf, "%*ph\n", (int)sizeof(at25->sernum), at25->sernum);
>  }
>  static DEVICE_ATTR_RO(sernum);
>  
> @@ -379,11 +379,11 @@ static int at25_probe(struct spi_device *spi)
>  	u8 sernum[FM25_SN_LEN];
>  	int i;
>  	const struct of_device_id *match;
> -	int is_fram = 0;
> +	unsigned long is_fram = 0;
>  
>  	match = of_match_device(of_match_ptr(at25_of_match), &spi->dev);
>  	if (match)
> -		is_fram = (int)match->data;
> +		is_fram = (unsigned long)match->data;
>  
>  	/* Chip description */
>  	if (!spi->dev.platform_data) {
> -- 
> 2.25.1
> 

Looks good, now queued up.

greg k-h

  reply	other threads:[~2021-06-11 14:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 14:27 [PATCH] nvmem: eeprom: at25: fix type compiler warnings Jiri Prchal
2021-06-11 14:45 ` Greg Kroah-Hartman [this message]
2021-06-11 14:47   ` Jiří Prchal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMN29rIlPDCL0w3A@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=ceggers@arri.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jiri.prchal@aksignal.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox