From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 371A1C48BE8 for ; Tue, 15 Jun 2021 21:07:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08D0A613C7 for ; Tue, 15 Jun 2021 21:07:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230001AbhFOVKC (ORCPT ); Tue, 15 Jun 2021 17:10:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbhFOVKC (ORCPT ); Tue, 15 Jun 2021 17:10:02 -0400 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2407C06175F for ; Tue, 15 Jun 2021 14:07:57 -0700 (PDT) Received: by mail-oi1-x235.google.com with SMTP id r16so57457oiw.3 for ; Tue, 15 Jun 2021 14:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PbZ0N3oI5rxba+H0GeCrLqD8E7sIQh2NCz/SFfq/xI0=; b=CaAcslFXiE8P1tk1USD6rRPo5zXsuvpEq9ZpHnyYRhWU+FTyJP8aWYAYXZtF62jrZE lRaR41ChtPdUEhFYpPsaGdAZ0IG3Fh9EmkQtqVlY/GPQ8v4CFHSpDxO4nPJwOiLYhXEQ hVdN3p598hLVTfc4d07OLK+d7cJIFGEwMTqBeGrMb8ggNqRC47u7gbDaiZG5D+DjiTiE L1OjdxD2MofN0s+LnQrMtlYZU/FdK4qWpOrBlezM28lCBeHQuMFM9NLuJiWmRwJFffvO 1oBncrdDVROOJdCx+7/Hx2I9hQ7HOBmZj1ZoTEmTn3cwbHqKDzomx2iiRzZVUNN10piY CaaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PbZ0N3oI5rxba+H0GeCrLqD8E7sIQh2NCz/SFfq/xI0=; b=rnCSjMM/tIkLdROr9Rxyg4x37uFbgR23cObq6wzSsGUABdosYEtaD9aTSZdI7aJ+jx 73bDf2Pd8eHP8y1ZGPMP6enWzShi2h8+8a8de6JzFDLIqV/MaFb/y5nanEN9+B5yDSti jqMvI3pXDlpcNDjdtXiiTY/Wj8RPzX7DL+R5UQYwDI5hlfAaDpgD3VguiRc+aEK4VlVs v4Vp7G+W0IGpM59a2wVGiqsD/fLKMqGzOk06ZTH3SfZHozswMkKek6n17gL2P8q/7E2m QDPVdVQWIyga5m2pc2kx4UlLK+XdWu/C1nBxKOYN9XpfXbomkDk58vX0tJ9dkoNPK7Mw +zKA== X-Gm-Message-State: AOAM532Zod5ni9NeiugRCYKH4uV5PK10hunpt/AbSWkQrS3rzNNr8Ywt ZBIc6jAxWL7jckAQOAOXvmquoA== X-Google-Smtp-Source: ABdhPJwxEwygKHn84iNtoFbYWINQIjWIRWBmB1/JU2TR3NYEDqRcp3PlD4dDHTiCjl0VfzEbyJ5Gew== X-Received: by 2002:a05:6808:9:: with SMTP id u9mr748714oic.48.1623791277134; Tue, 15 Jun 2021 14:07:57 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id m23sm24561otk.55.2021.06.15.14.07.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 14:07:56 -0700 (PDT) Date: Tue, 15 Jun 2021 16:07:55 -0500 From: Bjorn Andersson To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Linus Walleij , Liam Girdwood , Mark Brown , Vinod Koul , Rob Herring , Andy Gross Subject: Re: [PATCH v2 07/10] pinctrl: qcom/pinctrl-spmi-gpio: Add compatible for pmic-gpio on SA8155p-adp Message-ID: References: <20210615074543.26700-1-bhupesh.sharma@linaro.org> <20210615074543.26700-8-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615074543.26700-8-bhupesh.sharma@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue 15 Jun 02:45 CDT 2021, Bhupesh Sharma wrote: > SA8155p-adp PMIC (PMM8155AU) exposes 10 GPIOs. > > Add support for the same in the pinctrl driver. > > Cc: Linus Walleij > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Bjorn Andersson > Cc: Vinod Koul > Cc: Rob Herring > Cc: Andy Gross I don't think the Cc tags provides any value. > Signed-off-by: Bhupesh Sharma > --- > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > index 00870da0c94e..f886c683e2bd 100644 > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > @@ -1127,6 +1127,7 @@ static const struct of_device_id pmic_gpio_of_match[] = { > { .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 }, > /* pm8150l has 12 GPIOs with holes on 7 */ > { .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 }, > + { .compatible = "qcom,pmm8155au-gpio", .data = (void *) 10 }, But we want to keep these sorted alphabetically. Regards, Bjorn > { .compatible = "qcom,pm8350-gpio", .data = (void *) 10 }, > { .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 }, > { .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 }, > -- > 2.31.1 >