From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75413C49361 for ; Mon, 21 Jun 2021 06:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5618360FE7 for ; Mon, 21 Jun 2021 06:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229576AbhFUGU3 (ORCPT ); Mon, 21 Jun 2021 02:20:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:59668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbhFUGU2 (ORCPT ); Mon, 21 Jun 2021 02:20:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 877C76100B; Mon, 21 Jun 2021 06:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624256294; bh=YFZygVbRLxrAS2J28Fh5EQZmQgGwcUaOw0GMfbFbMUI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iqmDwOxrZLPQoYJ27yefzt4i0apxEJoiWDl6okQepYJuyM0oq1k2774163AhJOkNj 8TgJomOdjyk26J04eN6i16uJu2Mx/dhyh05IC0npJecRMjSDJek7JVHkuQ4nWMWdeX oYgac/cSufdvyDR6nvg9QpjaUKxYuOUtBtzGqgRHguqBpvYgv85cfuRxcMmCRCsaDa D6zhTII9kWmSxbxK3ZOhfyfkp0Kpo03ba0JPUYrkj/i50k7bQkf8ENcByZ9nNFP614 znf44JUyZFdoY5jOmF1N3Ewy2xzAocWYDvDEwEIwTeA42W3U2CE9Xr5s0RtbfYWAyv wsJvUTexufetw== Date: Mon, 21 Jun 2021 11:48:10 +0530 From: Vinod Koul To: Martin Blumenstingl Cc: robh+dt@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, kishon@ti.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 Message-ID: References: <20210604190338.2248295-1-martin.blumenstingl@googlemail.com> <20210604190338.2248295-3-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604190338.2248295-3-martin.blumenstingl@googlemail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04-06-21, 21:03, Martin Blumenstingl wrote: > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > region. Unfortunately only few register bits are documented. For > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > kernel. > > Signed-off-by: Martin Blumenstingl > --- > drivers/phy/amlogic/Kconfig | 11 ++ > drivers/phy/amlogic/Makefile | 1 + > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > 3 files changed, 162 insertions(+) > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > index db5d0cd757e3..e6c3a2a8b769 100644 > --- a/drivers/phy/amlogic/Kconfig > +++ b/drivers/phy/amlogic/Kconfig > @@ -2,6 +2,17 @@ > # > # Phy drivers for Amlogic platforms > # > +config PHY_MESON8_HDMI_TX > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > + default ARCH_MESON > + depends on (ARCH_MESON && ARM) || COMPILE_TEST depends on ARM seems redundant.. > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > + * > + * Copyright (C) 2020 Martin Blumenstingl 2021.. -- ~Vinod