From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BF52C49EA6 for ; Thu, 24 Jun 2021 12:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72497613F6 for ; Thu, 24 Jun 2021 12:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231129AbhFXMsd (ORCPT ); Thu, 24 Jun 2021 08:48:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:42342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbhFXMsd (ORCPT ); Thu, 24 Jun 2021 08:48:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 05D9C613EC; Thu, 24 Jun 2021 12:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624538773; bh=nC8A/O7w7HXv3o9pRB0mvbO1lJjk3ZH6cIfZZjwrzeI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S8PTOVXpfQ+ZhDtOYoAoQcAsCBHgG4m46P8u7tKG5fZUx8Burakc8onMSCLKu7X8E ysMyAlBH8OCwyQ73zg2oG1SIoMx4ng776ma1G8gFOXhGTWE+MqIR7Vs3WpqkwEjPp5 GpEoS9+9uw5tKBMFgdMPZ1V7PeQCfW74UHtYdEnw= Date: Thu, 24 Jun 2021 14:46:11 +0200 From: Greg Kroah-Hartman To: Geert Uytterhoeven Cc: Rob Herring , Alex Nemirovsky , Jason Li , "linux-serial@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann Subject: Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema Message-ID: References: <20210509184519.15816-1-alex.nemirovsky@cortina-access.com> <20210509184519.15816-2-alex.nemirovsky@cortina-access.com> <9937DB34-7757-4A54-BCC6-AF5514FD7F1D@cortina-access.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jun 22, 2021 at 01:28:06PM +0200, Geert Uytterhoeven wrote: > On Tue, Jun 15, 2021 at 6:21 PM Rob Herring wrote: > > On Tue, Jun 15, 2021 at 10:06 AM Alex Nemirovsky > > wrote: > > > > On Jun 15, 2021, at 8:44 AM, Rob Herring wrote: > > > > On Tue, Jun 15, 2021 at 8:39 AM Alex Nemirovsky > > > > wrote: > > > >> > > > >> > > > >> > > > >>> On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman wrote: > > > >>> > > > >>> On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote: > > > >>>> MAINTAINERS modification was made in the initial version 1. We made no changes to it since then, > > > >>>> thus not sure what we could at to Changelog which would add value or clarity for others > > > >>>> from the v1. > > > >>>> > > > >>>>> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman wrote: > > > >>>>> > > > >>>>> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote: > > > >>>>>> From: Jason Li > > > >>>>>> > > > >>>>>> Convert the Cortina-Access UART binding to DT schema format. > > > >>>>>> > > > >>>>>> Signed-off-by: Jason Li > > > >>>>>> --- > > > >>>>>> .../serial/cortina-access,serial.yaml | 46 +++++++++++++++++++ > > > >>>>>> .../devicetree/bindings/vendor-prefixes.yaml | 2 + > > > >>>>>> MAINTAINERS | 6 +++ > > > >>>>> > > > >>>>> You are also adding a MAINTAINERS entry here, which is not listed in the > > > >>>>> changelog text, so I couldn't take it anyway :( > > > >>> > > > >>> Add the maintainers entry in the first patch, with the driver please. > > > >> > > > >> The change to MAINTAINERS here add a new file into the DT documentation. > > > >> Should it not be grouped into the dt-binding portion and reviewed by the DT time for which this patch > > > >> is CC’ed to? Why would moving the DT documentation file that is introduced be into the first patch, which is the > > > >> serial driver itself be the correct approach? > > > > > > > > The binding doesn't actually need a MAINTAINERS entry (though having > > > > one is fine). get_maintainers.pl will also pull emails from the > > > > binding schema. > > > > > > > > Rob > > > > > > Hi Rob, > > > It sounds like you are find with patch 2/3 from a DT point of view. Could we review the rest from the DT point of view > > > to get either feedback for changes or ACK these, so we can unblock this series? > > > > Can't say I've seen it as I only see replies in my mail. Did this > > originally go to the DT list? If not, it's never in my queue[1]. > > > > Rob > > > > [1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/ > > None of the patches in this series ended up on a mailing list or on > lore, so no one could comment on them, except for people CCed directly. Ugh, I never noticed that I as I just applied one patch of the series, my fault. I'll go revert them from my tree now... thanks, greg k-h